Skip to content

Conversation

@IonesioJunior
Copy link
Member

@IonesioJunior IonesioJunior commented Mar 6, 2025

Pull Request Summary

  1. Description:
    This pull request introduces several enhancements to the apps.py module within the syftbox.client.plugins package. Key changes include:

    • Addition of the "USERPROFILE" environment variable to the get_clean_env function to ensure it is included in the environment setup.
    • Modification of how the application is checked for running status by using os.path.basename(app) instead of app.
    • Refactoring the environment variable setup in the run_custom_app_config function to utilize the get_clean_env function for cleaner code.
    • The logging mechanism has been adjusted to improve clarity, especially in error handling, by capturing exceptions and providing more informative log messages.
  2. Affected Dependencies:

    • The main file affected is syftbox/client/plugins/apps.py.
    • The changes also indirectly affect any modules or functionalities that rely on the get_clean_env and run_custom_app_config functions, particularly those related to app execution and logging.
  3. Test Additions:

    • No new tests were added in this change. The existing test suite should still cover the modified functionalities, but no explicit test files or locations for new tests were mentioned in the diff.

@yashgorana
Copy link
Contributor

Perhaps enable unit tests in https://github.com/OpenMined/syft/blob/main/.github/workflows/pr-tests.yaml ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants