Fixes for Windows Compatibility #548
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Description:
This pull request introduces several enhancements to the
apps.pymodule within thesyftbox.client.pluginspackage. Key changes include:get_clean_envfunction to ensure it is included in the environment setup.os.path.basename(app)instead ofapp.run_custom_app_configfunction to utilize theget_clean_envfunction for cleaner code.Affected Dependencies:
syftbox/client/plugins/apps.py.get_clean_envandrun_custom_app_configfunctions, particularly those related to app execution and logging.Test Additions: