Replace a few more deprecated pre-C++11 styles#1890
Open
aroffringa wants to merge 1 commit intoOpenLightingProject:masterfrom
Open
Replace a few more deprecated pre-C++11 styles#1890aroffringa wants to merge 1 commit intoOpenLightingProject:masterfrom
aroffringa wants to merge 1 commit intoOpenLightingProject:masterfrom
Conversation
DaAwesomeP
reviewed
Aug 4, 2023
Member
DaAwesomeP
left a comment
DaAwesomeP
left a comment
There was a problem hiding this comment.
I'm not really familiar with std::binary_function so I can't speak to those. I suppose we would see compile errors if it broke any typing.
Well I guess there isn't any more fun in the code! (sarcasm)
aroffringa
force-pushed
the
remove-deprecated-uses
branch
from
61256d9 to
c53a932
Compare
aroffringa
force-pushed
the
remove-deprecated-uses
branch
from
c53a932 to
782b768
Compare
Member
|
Wow, the syntax in StringUtils.cpp needs a bit getting used to. On the other hand, what we had before also was not that easy to read. I'd say: As long as this doesn't break stuff, reducing compiler warnings is a good thing! |
aroffringa
force-pushed
the
remove-deprecated-uses
branch
from
782b768 to
b138915
Compare
aroffringa
force-pushed
the
remove-deprecated-uses
branch
from
b138915 to
1beec8a
Compare
The functions std::binary_function and std::mem_fun have been deprecated in C++11, and are removed in C++20. This pull request replaces them with more modern code. Together with OpenLightingProject#1889 this removes all warnings on recent compilers.
aroffringa
force-pushed
the
remove-deprecated-uses
branch
from
1beec8a to
8aae4c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functions std::binary_function and std::mem_fun have been deprecated in C++11, and are removed in C++20. This pull request replaces them with more modern code. Together with #1889 this removes all warnings on recent compilers. This one is fairly small.