GitHub Actions Lint: weblint#1863
Conversation
peternewman
left a comment
There was a problem hiding this comment.
This should either be new web lint, or we should add a todo to potentially check the old Google Closure one too at some point...
Plus @FloEdelmann actions comment
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
|
@peternewman Annotation check is failing because Python 2.7 is no longer supported by EDIT: Opened #1865 |
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
I couldn't find this in the old Travis CI version. Was this ever tested/ran with the CI previously? |
peternewman
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fixes @DaAwesomeP !
I think this can definitely be a TODO/future issue/item in the main CI TODO, but it seems this was actually done on the RDM App, by @FloEdelmann as it happens: |
Added to the list in #1815! |
This one ended up being pretty simple!
@kripton I had to add a
package-lock.json. Please let me know if what I generated is acceptable or if you have a different version from your own machine. If the latter, then please push it to branch `0.10 or suggest/modify the file in this pull.