fix(#274,#275,#278,#344): doc-comment audit, risk-registry docs, CI cycle guard, ArithmeticUnderflow#363
Merged
OxDev-max merged 2 commits intoJun 30, 2026
Conversation
…undation#278,OpenLedger-Foundation#344): doc-comment audit, risk-registry docs, CI cycle guard, ArithmeticUnderflow OpenLedger-Foundation#274 - Bring all contracts up to marketplace's doc-comment standard: - access_control: full Params/Errors/Security on all 14 entrypoints - invoice_nft: full Params/Errors/Security on all 12 entrypoints - financing_pool: full Params/Errors/Security on all 19 entrypoints (fix propose_early_settlement missing block, remove duplicate one-liner on accept_early_settlement) - treasury: full Params/Errors/Security on all 12 entrypoints - risk_registry: full Params/Errors/Security on all 17 entrypoints OpenLedger-Foundation#275 - Document contract dependency graph and add CI cycle guard: - docs/ARCHITECTURE.md: acyclic dependency graph diagram + order - .github/workflows/ci.yml: cycle-guard job runs cargo tree on every PR and fails if a cycle is detected OpenLedger-Foundation#278 - Add dedicated risk registry documentation: - docs/risk-registry.md: verifier trust model, staking/slashing, SME registration/scoring lifecycle, debtor scoring, RiskTier thresholds, credit-limit enforcement, view functions, TTL notes OpenLedger-Foundation#344 - Fix undefined KoraError::ArithmeticUnderflow: - contracts/shared/src/errors.rs: add ArithmeticUnderflow = 91 so safe_sub compiles without error
|
@Joel234-png Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#274 - Bring all contracts up to marketplace's doc-comment standard:
#275 - Document contract dependency graph and add CI cycle guard:
#278 - Add dedicated risk registry documentation:
#344 - Fix undefined KoraError::ArithmeticUnderflow:
Closes #274
Closes #275
Closes #278
Closes #344