fix: add fail-fast error handling to deployment script#337
Merged
OxDev-max merged 2 commits intoJun 28, 2026
Merged
Conversation
Prevent cascading failures from silent errors in deploy_contract() and invoke() and correct the contract deployment order to respect constructor dependencies. Changes: - deploy_contract(): validate WASM file exists before calling stellar CLI, capture stdout into a variable, abort with a named error if the deploy command fails or returns an empty contract ID - invoke(): abort with contract-id + function name on any stellar CLI error - Reorder deployment section: access_control → invoice_nft → risk_registry → treasury → financing_pool → marketplace (matches constructor requirements: marketplace.initialize() needs invoice_nft, financing_pool, and treasury already live) - Echo all progress messages to stderr so captured contract IDs are clean - Pre-flight WASM existence check with actionable 'make build' hint Closes OpenLedger-Foundation#216
|
@Inkman007 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent cascading failures from silent errors in deploy_contract() and invoke() and correct the contract deployment order to respect constructor dependencies.
Changes:
Closes #216