fix(agent-server): share marketplace snapshot cache - #4785
Draft
Epochex wants to merge 1 commit into
Draft
Conversation
Co-authored-by: openhands <openhands@all-hands.dev>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HUMAN:
AGENT:
Why
The skills marketplace path checked for
marketplaces/default.jsonbefore manifest discovery. The current extensions repository publishes.plugin/marketplace.json, so a cold skills request could return an empty catalog while the plugins endpoint successfully loaded the same repository. The two endpoints also fetched and cached separate views.Summary
Issue Number
Fixes #4665
How to Test
uv run pytest tests/agent_server/test_marketplace_snapshot.py tests/agent_server/test_plugins_service.py tests/agent_server/test_skills_service.py -q— 56 passed.uv run pytest tests/agent_server/test_plugins_router.py tests/agent_server/test_skills_router.py -q— 51 passed.uv run pre-commit run --files openhands-agent-server/openhands/agent_server/marketplace_snapshot.py openhands-agent-server/openhands/agent_server/plugins_service.py openhands-agent-server/openhands/agent_server/skills_service.py tests/agent_server/test_marketplace_snapshot.py tests/agent_server/test_plugins_service.py tests/agent_server/test_skills_service.py— all hooks passed.The filesystem-backed regressions cover the real
.plugin/marketplace.jsonlayout, explicit fallback, fetch and parse failure retries, plugin-over-skill precedence, plugin filtering, shared fetches, and fresh installation state.Video/Screenshots
Not applicable; this is backend catalog loading.
Design Doc
Not applicable; the change consolidates two existing private caches without changing REST schemas.
Type
Notes
The five-minute in-process TTL is unchanged. Failed fetches or parses are not cached, so the next request retries.