Skip to content

chore: remove merged PR artifacts - #842

Open
all-hands-bot wants to merge 1 commit into
mainfrom
automation/remove-pr-artifacts
Open

all-hands-bot wants to merge 1 commit into
mainfrom
automation/remove-pr-artifacts

Conversation

@all-hands-bot

Copy link
Copy Markdown
Contributor

Why

Temporary .pr/ artifacts reached main through one or more merged PRs.

Summary

  • Remove the temporary .pr/ directory from main.

How to Test

  • Confirm this PR only deletes files under .pr/.
  • Let the required checks validate the cleanup commit.

This PR was automatically created by the PR Artifacts workflow.

@all-hands-bot all-hands-bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review was posted by an AI agent (OpenHands).

Scope gate

This change belongs in this repository. AGENTS.md ("PR-specific documents") defines .pr/ as a temporary artifacts directory whose post-merge cleanup is owned by the PR Artifacts workflow (.github/workflows/pr-artifacts.yml), which opens cleanup PRs exactly like this one. No repository move or maintainer decision is needed.

Findings

No material issues. The PR deletes only files under .pr/ (4 files: verification.md and 3 binary evidence images, +0 -50), matching the stated purpose. No source, catalog, manifest, workflow, or build input is touched. .pr/ remains ignored in .npmignore and the PR Artifacts workflow for future PRs, so nothing is removed prematurely.

Verification

  • Current head is 715302f33b940c47bf25771f08725ab7e443d2c8; PR state, title, body, and labels re-read immediately before this review and unchanged from the trigger snapshot. No prior reviews or comments existed, and no linked issues were referenced (the cross-referenced PR #841 is already merged).
  • All 10 GitHub Actions checks on this head are green (2 skipped by design), including Tests/test, Check Extensions/sync-extensions, sync-sdk-skill, validate-claude-code, PR Artifacts/check-pr-artifacts, and the PR description check.
  • Full local test suite on this exact head: 1433 passed, 23 skipped (focused catalog and SDK-loading tests included). Working tree left clean; only the disposable virtualenv created to run the suite was removed.

The cleanup is safe to merge and completes the expected post-merge artifact removal.

✅ APPROVED

Co-authored-by: openhands <openhands@all-hands.dev>

@all-hands-bot all-hands-bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review was posted by an AI agent (OpenHands).

Scope gate

This change belongs in this repository. AGENTS.md ("PR-specific documents (.pr/)") defines .pr/ as a temporary artifacts directory whose post-merge cleanup is owned by the PR Artifacts workflow, which opens cleanup PRs exactly like this one. No repository move or maintainer decision is needed.

Findings

No material issues on head db609f4. The PR deletes only the four files under .pr/kanban-migration/ (+0 -50: verification.md plus three binary evidence images), matching the stated cleanup purpose. No source, catalog, manifest, workflow, or build input is touched. .pr/ remains excluded in .npmignore and covered by the PR Artifacts workflow, so the mechanism for future PRs is unaffected.

Verification (re-run for the new head)

  • Head re-checked immediately before this review: current head is db609f48697373d5771dafb4998986fe042b38cf, PR open and non-draft, title, body, and type: chore label unchanged from the trigger snapshot. The branch was rebased onto current main (bcb411d); the diff against main remains exactly the four .pr/ deletions.
  • Prior review by this account was posted against the previous head 715302f; the head has since moved, so this fresh pass supersedes it. No comments from other users were posted since.
  • All 11 GitHub Actions checks on this head are green (2 skipped by design), including Tests/test, Check Extensions/sync-extensions, sync-sdk-skill, validate-claude-code, PR Artifacts/check-pr-artifacts, and the PR description check.
  • Full local test suite on this exact head: 1433 passed, 23 skipped. Working tree left clean; only the disposable virtualenv created to run the suite was removed.

Cross-referenced PRs (#841, #819) are both closed/merged, so the artifacts are safely removable. The cleanup is safe to merge.

✅ APPROVED

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: chore Maintenance / chores

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant