Repository navigation
fix(keycloak): use wildcard redirect URI for /oauth/ callbacks - #1377
Merged
Merged
Conversation
Replace the three explicit /oauth/keycloak/callback,
/oauth/keycloak/offline/callback, and /oauth/device/keycloak-callback
redirect URIs on the allhands client with a single
https://$WEB_HOST/oauth/* entry.
This also covers the new /oauth/{n}/callback pattern, where {n} is an
unbounded database primary key and can't be enumerated as exact
redirect URIs. Keycloak only supports a single trailing wildcard, so a
prefix match anchored on the full host plus the required /oauth/
literal is the narrowest pattern that still covers this.
Co-authored-by: openhands <openhands@all-hands.dev>
tofarr
requested review from
aivong-openhands,
dylan-openhands,
jlav and
mamoodi
as code owners
October 9, 2026 11:47
aivong-openhands
approved these changes
Oct 9, 2026
Contributor
|
🚀 Released in openhands/0.80.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the three explicit /oauth/keycloak/callback, /oauth/keycloak/offline/callback, and /oauth/device/keycloak-callback redirect URIs on the allhands client with a single https://$WEB_HOST/oauth/* entry.
This also covers the new /oauth/{n}/callback pattern, where {n} is an unbounded database primary key and can't be enumerated as exact redirect URIs. Keycloak only supports a single trailing wildcard, so a prefix match anchored on the full host plus the required /oauth/ literal is the narrowest pattern that still covers this.
Description
Helm Chart Checklist
Additional Notes