Skip to content

feat(openhands): PLTF-1247 make Valkey the bundled cache - #1008

Open
aivong-openhands wants to merge 3 commits into
mainfrom
pltf-1247-valkey-cutover
Open

aivong-openhands wants to merge 3 commits into
mainfrom
pltf-1247-valkey-cutover

Conversation

@aivong-openhands

@aivong-openhands aivong-openhands commented Aug 3, 2026 •

Copy link
Copy Markdown
Contributor

Why

Turns on the cache backend the previous change made available, so new and upgraded installs run the maintained
Valkey chart instead of the frozen Bitnami Redis one. The status informers, the support-bundle analyzer and the
architecture diagram move with it, since a status informer left pointing at a workload that no longer exists shows
the app as Unavailable.

Existing installs lose the cache contents at upgrade. Conversations continue, sign-in sessions are unaffected
because they do not live in the cache, and rate limiting briefly allows requests it would otherwise have counted.

Redis is still declared in the chart, so going back is redis.enabled: true and nothing else.

Validation

  • Upgrade and rollback on every consumer surface — measured in feat(openhands): PLTF-1247 migrate embedded Redis to Valkey #973 on published charts, on the Replicated
    registry via the customer path (install from Stable, switch channel, upgrade), and on Embedded Cluster, each
    direction confirmed by a completed conversation writing rate-limiter keys into the live cache.
  • The status informers name workloads the chart actually renders — deployment/openhands-valkey and
    service/openhands-valkey in replicated/application.yaml match the rendered Deployment/openhands-valkey and
    Service/openhands-valkey. Nothing automated checks that agreement across the two files.
  • Checked which consumers this actually moves, and when. Replicated installs follow the chart in the release,
    so they cut over as soon as a release carrying this is promoted. The internal SaaS environments each pin a chart
    version in their own Chart.yaml, so none of them moves until that pin is bumped — and staging and production
    pin 1Gi/500m under redis.master.resources with no enabled key, so whichever change bumps their pin has to
    carry their Valkey values too or their cache silently falls to the chart's 100m/128Mi. Development and feature
    set redis.enabled: true explicitly and stay on Redis either way.

This PR was drafted by an AI agent on behalf of the user.

@github-actions github-actions Bot added the type: feat A new feature label Aug 3, 2026
@aivong-openhands
aivong-openhands force-pushed the pltf-1247-valkey-opt-in branch 2 times, most recently from eeab93b to 340e29f Compare August 3, 2026 16:29
@aivong-openhands
aivong-openhands force-pushed the pltf-1247-valkey-cutover branch from 2931701 to b0cc61e Compare August 3, 2026 16:31
Base automatically changed from pltf-1247-valkey-opt-in to main August 3, 2026 17:55
Flips the chart default and the Replicated values to Valkey, and moves the
status informers, support-bundle analyzer and architecture diagram with it.

Redis stays declared and wins whenever it is re-enabled, so an install that
hits a problem reverts with redis.enabled: true and nothing else.
@aivong-openhands
aivong-openhands force-pushed the pltf-1247-valkey-cutover branch from b0cc61e to eafc6f1 Compare August 3, 2026 19:12
@aivong-openhands
aivong-openhands marked this pull request as ready for review August 3, 2026 19:16
@aivong-openhands

Copy link
Copy Markdown
Contributor Author
  • Discuss with FDEs on the rollout timing. Do not merge until then

@aivong-openhands

Copy link
Copy Markdown
Contributor Author

@OpenHands fix conflicts

@openhands-ai

openhands-ai Bot commented Aug 5, 2026

Copy link
Copy Markdown

I'm on it! aivong-openhands can track my progress at all-hands.dev

Resolve the Replicated values overlap by keeping the Valkey cutover alongside main's durable filestore configuration.\n\nCo-authored-by: openhands <openhands@all-hands.dev>

Copy link
Copy Markdown
Contributor Author

Conflicts with main are resolved in commit 7002236. The resolution keeps the Valkey cutover and incorporates the durable MinIO filestore changes from main.

Validated locally:

  • helm unittest charts/openhands — 77 passed
  • helm lint charts/openhands
  • helm template charts/openhands --debug
  • focused troubleshoot template tests — 6 passed
  • git diff --check

GitHub now reports the PR as mergeable; CI is running. I did not merge the PR, preserving the FDE rollout hold.

This comment was generated by an AI agent (OpenHands) on behalf of the user.

@openhands-ai

openhands-ai Bot commented Aug 5, 2026

Copy link
Copy Markdown

OpenHands encountered an error: **Failed to fetch final response from agent server: HTTP 503 error: no available server
**

See the conversation for more information.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feat A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants