fix(daemon): persist battery_auto_switch_mode setting at daemon startup#65
Merged
Conversation
Collaborator
|
Hi, thanks for your time, LGTM! |
luytan
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when the daemon restarted it didn't take into account the AC automatic mode value inside the config (
cardwire.toml) and always used Smart. I looked in the code and found the issue where the battery auto-switch mode was hardcoded instead of getting it from the config. I fixed the issue but noticed too late in discord that you already intended to fix it. Here is what I would have done anyway based on what was already there.