Skip to content
This repository was archived by the owner on Apr 11, 2024. It is now read-only.

Initial Project and Service added#388

Draft
aftabkajal wants to merge 5 commits intomainfrom
feature/attendance-service-initial-implementation
Draft

Initial Project and Service added#388
aftabkajal wants to merge 5 commits intomainfrom
feature/attendance-service-initial-implementation

Conversation

@aftabkajal
Copy link
Contributor

@aftabkajal aftabkajal commented Apr 23, 2021

The initial project added for the Attendance service. @ratanparai Bhai bro, could you please update the docker file for this service?

@aftabkajal aftabkajal requested a review from ratanparai April 23, 2021 22:10
@ratanparai
Copy link
Member

ratanparai commented Apr 24, 2021

@aftabkajal: Can you please ensure that your PR build without docker?

You can run the following command to build the solution from the root directory of the repository -

dotnet build eSchool.sln

Please let me know after you fix the build error. I will create the Dockerfile after that.

@aftabkajal
Copy link
Contributor Author

aftabkajal commented May 1, 2021

@aftabkajal: Can you please ensure that your PR build without docker?

You can run the following command to build the solution from the root directory of the repository -

dotnet build eSchool.sln

Please let me know after you fix the build error. I will create the Dockerfile after that.

Hello @ratanparai bro. build issue resolved. could you please check now?

@ratanparai
Copy link
Member

ratanparai commented May 29, 2021

@aftabkajal: The folder name is Attendance.API but the project name is Attending.API. Please use the same name for consistency.

ratanparai
ratanparai suggested changes Jun 12, 2021
View reviewed changes
eSchool.sln
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Libraries", "Libraries", "{74511F4E-FF9D-42C4-9531-A75C61270B73}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "OpenTelemetry", "src\Libraries\OpenTelemetry\OpenTelemetry.csproj", "{7B410F3B-36E0-4853-9B4E-41D0CC2865B5}"
Copy link
Member

@ratanparai ratanparai Jun 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please skip adding your projects to the solution file? This way your project should not be visible in visual studio, but can be built from command line.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mahedee mahedee Awaiting requested review from mahedee mahedee will be requested when the pull request is marked ready for review mahedee is a code owner

1 more reviewer

@ratanparai ratanparai ratanparai requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

do-not-merge size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aftabkajal @ratanparai