Repository navigation
refactor(data_sources): remove duplicate unknown-market warning in normalize_market - #285
Merged
brokermr810 merged 1 commit intoOct 15, 2026
Conversation
…rmalize_market The unknown-market branch in DataSourceFactory.normalize_market() emitted the same warning twice: once through _log_limited() (deduplicated) and once through a plain logger.warning() left over from an earlier refactoring, which bypassed log deduplication. Drop the legacy logger.warning() call so the branch logs exclusively via _log_limited(), consistent with the other failure branches in this factory (kline, ticker, fd-cooldown, ticker-batch). No behavior change for callers: unknown market categories are still logged and passed through unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logger.warning(...)block left over inDataSourceFactory.normalize_market()after the migration to_log_limited()._log_limited(), and once via a plainlogger.warning()that bypassed log deduplication._log_limited().Behavior
No caller-visible behavior change: unknown market categories are still logged (once per key per dedup window, with a suppressed-duplicate count) and passed through unchanged.
Testing
python3 -c "import ast; ast.parse(...)"— passed.