chore: bump prop for NSEC compression + per-record multicast floor - #375
Merged
Conversation
…t floor Picks up two mDNS fixes from the 6.3.0+34 capture: NSEC records now compress their 'Next Domain Name' to the two-byte form RFC 6762 §6.1 says implementations are only required to parse, and the §6 multicast floor is keyed per record instead of per service, so an A answer no longer suppresses the NSEC that answers AAAA for the same hostname. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PanTG9kRBi4QTQ2psvpTxP
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the prop Git submodule pointer to pick up upstream mDNS fixes (NSEC “Next Domain Name” compression and per-record multicast floor behavior) referenced in the PR description.
Changes:
- Bump
propsubmodule from23e03e23af77cb9529a04bbdbaf56c3f3197bb4cto3c470f3bb272cca2cc29bb205b675c23a1042927.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
LGTM |
Collaborator
Author
|
I appreciate your opinion on this matter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submodule bump only — the fixes are in OpenBikeControl/prop#4.
Context
Tester on 6.3.0+34: still requires the
tnctrick. The capture does confirm the previous round landed — all three interface sockets now receive multicast answers where only one did — but it exposes two more defects:QU AAAA … → unicast ×81, never once multicast. On a shared 5353 that is the indeterminate delivery path, which matches the long-standing "disable IPv6" workaround inINSTRUCTIONS_WINDOWS_IPV6.md.Expectations
Both are real, spec-cited defects and the second is a regression I introduced two rounds ago. Neither is proven to fix the tester — the client is resolving the current hostname and still failing. If this build still needs
tnc, a Wireshark capture onudp port 5353is the honest next step.🤖 Generated with Claude Code
https://claude.ai/code/session_01PanTG9kRBi4QTQ2psvpTxP