Xlnx add trace buf and update address space#98
Open
tnmysh wants to merge 4 commits intoOpenAMP:mainfrom
Open
Conversation
Collaborator
tnmysh
commented
Mar 13, 2026
tnmysh
commented
- Add trace buffer support
- Update current DDR addresses to match latest system device-tree standards
- fix trivial compiler warning during building matrix multiply demo
- Allow native cmake build
If xlnx toolchain is not used to build demos, then allow building xlnx demos with native cmake build system. Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
fix following compiler warning:
warning: passing argument 1 of 'rpmsg_matrix_app' fr
om incompatible pointer type [-Wincompatible-pointer-types]
47 | rpmsg_matrix_app(rpdev, platform);
| ^~~~~
Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
trace buffer is a circular buffer to store logs. Linux remoteproc subsystem creates a debugfs file that can be used to print these logs on linux side. Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
tnmysh
force-pushed
the
xlnx_add_trace_buf_and_update_address_space
branch
from
f6a6178 to
833a6b4
Compare
arnopo
requested changes
Mar 18, 2026
| #include <openamp/open_amp.h> | ||
| #include <openamp/version.h> | ||
| #include "platform_info.h" | ||
| #include "platform_info_common.h" |
Collaborator
There was a problem hiding this comment.
split in 2 patches one for the platform agnostic part example on for the AMD/Xilinx machine update
| @@ -11,7 +11,7 @@ endif(EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/${PROJECT_SYSTEM}/gic_init.c") | |||
|
|
|||
| # If not provided, add default value for resource table | |||
Collaborator
There was a problem hiding this comment.
commit message need to be reworked
legacy_apps: xlnx: update reserved mem regions as per latest carveouts
explain the reason of the update
Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
|
|
||
| /* Init circular buffer */ | ||
| circ.c_buf = get_rsc_trace_info(&circ.c_len); | ||
| if (circ.c_buf && circ.c_len) |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (circ.c_buf && circ.c_len) | |
| if (!circ.c_buf || !circ.c_len) | |
| metal_err("invalid trace buffer\n"); |
| "notice", | ||
| "info", | ||
| "debug", | ||
| }; |
Collaborator
There was a problem hiding this comment.
put it before the if condition as it is a variable declaration
| len = sprintf(msg, "%s: ", level_strs[level]); | ||
|
|
||
| if (len < 0 || len > (int32_t)sizeof(msg)) | ||
| len = 0; |
Collaborator
There was a problem hiding this comment.
what about just using snprintf() and remove test on len?
len = snprintf(msg, sizeof(msg), "%s: ", level_strs[level]);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.