fix(i18n): route print progress strings through i18next#282
Open
art804 wants to merge 1 commit into
Open
Conversation
The print job's progress toasts and error messages were hardcoded Dutch, bypassing the translation system - non-Dutch users saw Dutch text while printing. Move all seven strings to dialogs:print.progress keys with en and nl translations (other languages fall back to en).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The print job's progress toasts and error messages were hardcoded Dutch, so
non-Dutch users see Dutch text while printing (e.g. "Afdrukken voorbereiden…",
"Afdrukken mislukt: …").
Moved all the print-progress strings to
dialogs:print.progresskeys withenand
nltranslations (the Dutch originals are preserved verbatim as thenlvalues). Other languages fall back to English until translated. The three
placeholders — page render progress, copy N of M, and the error message — use
i18next interpolation.
No behavioural change beyond the displayed language;
print-job.jscalls thesame progress functions, now with translated strings.