Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4271 +/- ##
==========================================
- Coverage 32.76% 32.66% -0.11%
==========================================
Files 482 483 +1
Lines 57036 57181 +145
==========================================
- Hits 18688 18678 -10
- Misses 35077 35230 +153
- Partials 3271 3273 +2 |
Contributor
❌ 5 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
MishkaRogachev
force-pushed
the
transaction-address-collection-filter-events
branch
from
c30dcd7 to
4bb6f91
Compare
MishkaRogachev
force-pushed
the
transaction-address-collection-filter-events
branch
from
4bb6f91 to
84f9e1e
Compare
MishkaRogachev
changed the title
tsahee
requested changes
Jan 30, 2026
Contributor
tsahee
left a comment
tsahee
left a comment
There was a problem hiding this comment.
overall this is looking great. Very small comments
| return NewEventFilter(config.Rules) | ||
| } | ||
|
|
||
| func NewEventFilterFromFile(path string) (*EventFilter, error) { |
Contributor
There was a problem hiding this comment.
seems like this and the one above it would be better off returning just rules instead of filter and then you only create a filter once.
| } | ||
|
|
||
| // ExtractAddresses returns all addresses referenced by this event rule verbatim. | ||
| func (f *EventFilter) ExtractAddresses(topics []common.Hash, _data []byte, _emitter common.Address, _sender common.Address) []common.Address { |
Contributor
There was a problem hiding this comment.
(not a must) to me the name sounds like mid-step, not suggesting that bypass is also taken into account.. maybe call it something like FilteredAddresses? .. not sure at all about that one.
Contributor
Author
There was a problem hiding this comment.
Changed to AddressesForFiltering
| } | ||
|
|
||
| // Helper function to compute selector from event signature, used for test purposes only. | ||
| func Selector4(sig string) [eventSelectorSize]byte { |
Contributor
There was a problem hiding this comment.
can you use the full behavior here, which is currently implemented as part of ParseSelector? (and also use this function from parseSelector)
The extra time parsing, computing canonical etc. is not a problem for tests, and I'd rather have just one correct implementation rather then risk someone calling this function later for production code.
Contributor
Author
There was a problem hiding this comment.
Fixed + removed duplication from Validate()
tsahee
approved these changes
Jan 31, 2026
| return &EventFilter{rules: m}, nil | ||
| } | ||
|
|
||
| func NewEventFilterFromConfig(cfg EventFilterConfig) (*EventFilter, error) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes NIT-4250 and NIT-4251
In this PR: