Feature/frostfall compatibility#31
Open
angrmgmt wants to merge 9 commits intoOdie:feature/frostfall-compatibilityfrom
Open
Feature/frostfall compatibility#31angrmgmt wants to merge 9 commits intoOdie:feature/frostfall-compatibilityfrom
angrmgmt wants to merge 9 commits intoOdie:feature/frostfall-compatibilityfrom
Conversation
Edited the 25 AS scripts needed to support the 6 SWF files modified by Chesko to enable Warmth/Coverage display in SkyUI for Frostfall. JPEXS was used for SWF decoding, WinMerge was used to diff/merge, forwarding changes from SkyUI VR to outdated files provided by Sthagg for Frostfall SE support.
This reverts commit 0f6bf28.
Trying with non-decompiled source files from both repos. Same diff/merge process. Found a trial of Adobe Flash Pro CS6. Cross fingers.
Took out a duplicated definition for SetPlatform in ContainerMenu.as that I accidentally left in. Re-built with CS6 and it runs in-game, now just need the frames to display values instead of variable names.
Uncommented debug lines and prepended source file name to log text. Did some cleanup as it appears it has been a while since these needed testing. Enabled `FetchProtectionDataForList` in CraftingMenu.as for testing. Built and tested in-game: After completing Frostfall quest via MCM, warmth/coverage values display in ItemCard (though not overall values at bottom of inventory). All spells/powers added as appropriate. Weathersense does not work inside (as expected) but correct "error" is given. Active Effects show current exposure. Log file results puzzling in context... perhaps those are more deprecated than I thought...
Finally figured out that you have to "Break Apart" the items in the timeline to actually see their pieces. Not a fan of the "IDE", would much rather write UI code. Regardless, updates to all screens are now complete. Code is merged (hopefully correctly) and all that remains is to test as extensively as possible... with user support! :)
Fixed a leak caused by some weird list->element->list recursion in CraftingMenu. Moved logging in BottomBar to a more useful place in the logic, and homogenized it. Took some notes. Trying to track down erroneous display of '0undefined' in BottomBar when viewing non-equipment items.
Found and fixed the display of 0 and undefined when previous coverage delta was undefined. Maybe overkill but if I can't maintain it...
Removed debug logging.
Owner
|
Will merge when I stop being lazy! =) |
|
I would really like to have this feature "officially" supported. Still being lazy? ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented Frostfall Compatibility by diff/merge with files available at https://github.com/chesko256/Campfire. Edits to squash bugs.