Repository navigation
21-22-23 Temmuz yapılanlar: API gateway async job akışı, gerçek gRPC … - #26
Closed
ElifFCebeci wants to merge 1 commit into
Closed
ElifFCebeci wants to merge 1 commit into
ElifFCebeci wants to merge 1 commit into
Conversation
…bağlantısı ve iyileştirmeler
Collaborator
|
Thanks for the work here — the changes themselves look solid, but I have to request changes before this can be merged. PR description must be in English. Please rewrite the summary, scope, and test plan sections in English so the whole team can review consistently. Once these are updated, happy to take another pass. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Açıklama:
Özet
/enhanceve/enhance/batchartık sahte 202 yanıtı yerine gerçek async job akışı çalıştırıyor: Redis'te QUEUED -> RUNNING -> COMPLETED/FAILED, sonuçGET /enhance/{job_id}ile sorgulanıyor./healthve/modelsartık gerçekHealth/ListModelsgRPC çağrılarına bağlı (statik mock kaldırıldı).UNAVAILABLEiçin retry/backoff./metrics, route bazlı upload boyutu sınırı (413), graceful shutdown (SIGINT/SIGTERM'de arka plandaki job'lar bitmeden Redis/gRPC kapanmıyor).api/openapi.yamlüretildi;common.proto'dakiJobStatusyorumu async modele göre güncellendi.Kapsam dışı
services/ml/inference_server(Python gRPC sunucusu) bu PR'a dahil değil, hâlâ yazılmadı — gateway şu an karşı taraf olmadığı için/health,/models, job'lar "unreachable/failed" dönecek, bu beklenen.Test planı
go build ./...,gofmt -l .,go vet ./...temiz/enhance→ 202 → job kaydı, olmayan job için 404, 25MB üstü dosya için 413,/health+/modelsgRPC yokken doğru hata mesajı, CORS izinli/izinsiz origin