simplify base flex structure#1
Merged
michael-petersen merged 2 commits intoObservationalExpansions:mainfrom Nov 11, 2025
Merged
simplify base flex structure#1michael-petersen merged 2 commits intoObservationalExpansions:mainfrom
michael-petersen merged 2 commits intoObservationalExpansions:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes alternative Cython and Numba implementations of the FLEX library, simplifying the codebase to maintain only the base implementation. The changes also update repository URLs to reflect the new organization ownership.
- Removes Cython-based implementation (
FLEXCclass andlaguerre_cythonmodule) - Removes Numba-based implementation (
FLEXYclass fromflexnumbamodule) - Updates repository URLs from
michael-petersentoObservationalExpansions
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/flex/laguerre_cython.pyx | Deleted Cython implementation of Laguerre polynomial evaluation functions |
| src/flex/flexnumba.py | Deleted Numba-based FLEXY class and JIT-compiled Laguerre functions |
| src/flex/flexcython.py | Deleted FLEXC class that used the Cython Laguerre implementation |
| src/flex/init.py | Removed imports and exports for FLEXY and FLEXC, keeping only base FLEX class |
| setup.py | Removed Cython extension configuration and build setup |
| README.md | Updated repository URLs to new organization (ObservationalExpansions) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
8a47914
into
ObservationalExpansions:main
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original FLEX code had experimental compiled versions in it; for ease of use this PR removes those to a separate branch. This PR should be considered a candidate for
v1.0.