Skip to content

Fix missing saturatedPressure unit conversion in SSMT boiler#8570

Draft
Copilot wants to merge 2 commits into
developfrom
copilot/new-steam-assessment-unit-conversion
Draft

Fix missing saturatedPressure unit conversion in SSMT boiler#8570
Copilot wants to merge 2 commits into
developfrom
copilot/new-steam-assessment-unit-conversion

Conversation

Copilot AI commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • Variable, function, and class names are descriptive
  • Code leverages existing architecture, helper methods, and shared modules when applicable
  • Development artifacts such as console logs, test values, and comments have been removed
  • All Copilot, Claude Code, or other LLM implementations have been reviewed as if contributed by another developer
  • UI changes have been manually tested for usability and appearance
  • This PR references the related issue number (if applicable), ex. issue -> #0000

Description

When a user changes pressure units in SSMT Assessment Settings and accepts the "update data" prompt, the Steam Pressure (saturatedPressure) field on the Boiler tab was not being converted — it retained its value in the old unit. Only deaeratorPressure was handled in the conversion block; saturatedPressure (added as part of the Saturated/Superheated steam update) was omitted.

  • convert-ssmt.service.tsconvertBoiler(): Added saturatedPressure to the pressure unit conversion block alongside deaeratorPressure.
if (oldSettings.steamPressureMeasurement != newSettings.steamPressureMeasurement) {
  boilerInput.saturatedPressure = this.convertValue(boilerInput.saturatedPressure, oldSettings.steamPressureMeasurement, newSettings.steamPressureMeasurement);
  boilerInput.deaeratorPressure = this.convertValue(boilerInput.deaeratorPressure, oldSettings.steamPressureMeasurement, newSettings.steamPressureMeasurement);
}

Applies to both Saturated (measured by pressure) and Superheated steam configurations.


Copilot AI changed the title [WIP] Fix unit conversion for steam assessment fields Fix missing saturatedPressure unit conversion in SSMT boiler Jun 10, 2026
Copilot AI requested a review from nbintertech June 10, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New steam assessment fields need post-data entry unit conversion

2 participants