Issue 8547: Round 2.Adding Missing fields, Adding Validation, Removing duplicates#8558
Draft
WoodrowKromar wants to merge 3 commits into
Draft
Issue 8547: Round 2.Adding Missing fields, Adding Validation, Removing duplicates#8558WoodrowKromar wants to merge 3 commits into
WoodrowKromar wants to merge 3 commits into
Conversation
nbintertech
approved these changes
Jun 9, 2026
nbintertech
left a comment
Collaborator
There was a problem hiding this comment.
By and large looks good. A few notes on the things (I believe) you're still in progress on:
- Keep validation message language for mins/maxes as closely as you can with what the app is doing in assessments
- If the min/max values came from some named domain constraint in the document, assign a const with the domain name, or include that in a comment with the static value passed to the validator. Example
const boilingPointOfWater = 212
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8547