Skip to content

Issue 8547: Round 2.Adding Missing fields, Adding Validation, Removing duplicates#8558

Draft
WoodrowKromar wants to merge 3 commits into
epic-steam-leak-surveyfrom
Issue-8547
Draft

Issue 8547: Round 2.Adding Missing fields, Adding Validation, Removing duplicates#8558
WoodrowKromar wants to merge 3 commits into
epic-steam-leak-surveyfrom
Issue-8547

Conversation

@WoodrowKromar

Copy link
Copy Markdown
Contributor

#8547

  • Adjusted Estimate, Orifice, and Plume forms with additional fields from the Calculator Template. Added adjustments to form logic in services.
  • Centralized pressureReductionMethods and pass it as an input.
  • Added Validation logic for fields and forms. Validation taken from the Calculator Template Document.
  • I adjusted the Min value of Feedwater Temperature to 32 deg as its not Feedice Temperature. The document has a 0 deg constraint, but seems like a mistake.

@WoodrowKromar WoodrowKromar requested a review from nbintertech June 9, 2026 17:34

@nbintertech nbintertech left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By and large looks good. A few notes on the things (I believe) you're still in progress on:

  • Keep validation message language for mins/maxes as closely as you can with what the app is doing in assessments
  • If the min/max values came from some named domain constraint in the document, assign a const with the domain name, or include that in a comment with the static value passed to the validator. Example const boilingPointOfWater = 212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants