Open
Conversation
totto82
added
the
manual:enhancement
Member
Author
|
jenkins build this opm-simulators=6756 please |
1 similar comment
Member
Author
|
jenkins build this opm-simulators=6756 please |
svenn-t
reviewed
Jan 27, 2026
Contributor
svenn-t
left a comment
svenn-t
left a comment
There was a problem hiding this comment.
Just a small comment that depends on how the default is handled in OPM/opm-simulators#6756. Otherwise it looks good to me!
| "name": "TRGDDT", | ||
| "value_type": "DOUBLE", | ||
| "dimension": "Temperature", | ||
| "default": 0.1 |
Contributor
There was a problem hiding this comment.
If a safeguard is put in place to not enforce this default for simulations without temperature model, then this default is OK.
Member
Author
|
jenkins build this opm-simulators=6756 please |
1 similar comment
Member
Author
|
jenkins build this opm-simulators=6756 please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.