Classify Sparkle security updates from release tags#105
Merged
Conversation
Pass immutable annotated-tag metadata through the release workflow to generate signed critical-update appcasts with canonical GitHub archive and release URLs. Extend the appcast contract and regression coverage. Refs #57.
jmcte
marked this pull request as ready for review
July 12, 2026 10:47
jmcte
enabled auto-merge (squash)
July 12, 2026 10:51
This was referenced Jul 12, 2026
athena-omt
approved these changes
Jul 12, 2026
athena-omt
left a comment
Contributor
There was a problem hiding this comment.
Athena review: approved.
Evidence checked:
- Branch head 08b63f7 is based on current main 7433d2e, so this review is against a fresh head.
- Live checks are green on the latest run: Rust test, Rust checks/lint, PR Fast CI gate, Fast Checks, and secrets validation. The cancelled PR Fast CI entries are from the superseded run, followed by successful rerun entries.
- Auto-merge is already enabled with squash.
- Focused local checks passed on OMT-NAS:
bash scripts/test-prepare-sparkle-appcast.shandbash scripts/ci/validate-appcast-contract.sh.
I did not find a blocking issue in the annotated-tag critical-update flow, generator argument forwarding, appcast contract checks, or release-note security-section guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Governing Issue
Refs #57
This advances the remaining in-app update release contract. It does not close #57: the first signed/notarized production release and live appcast still require configured Apple signing/notary credentials and Sparkle release variables.
Validation
bash scripts/test-prepare-sparkle-appcast.shbash scripts/ci/validate-appcast-contract.shbash -n scripts/prepare-sparkle-appcast.sh scripts/test-prepare-sparkle-appcast.sh scripts/ci/validate-appcast-contract.shruby -e 'require "yaml"; YAML.load_file(".github/workflows/release.yml")'\n-bash scripts/ci/run-fast-checks.sh\n-git diff --check\n\n## Release use\nCreate a normal tag for an ordinary update. For a security update, create an annotated tag containing:\n\ntext\nAPW-Sparkle-Critical-Update-Version: all\n\n\nUse a concrete Sparkle version instead ofallwhen the critical prompt should apply only through that installed version.