Skip to content

Conversation

@oleg-odysseus
Copy link
Contributor

Implements OHDSI/Atlas/issues/3024

  • Enriched existing concept set compare to allow comparing concept sets over different vocabularies
  • Added Batch Compare (new asynchronous job to track how vocabulary changes affect a subset of concept sets selected by multiple filtering criteria)

[compare] added api operation, updated error message to support comparing the same concept set over different vocabularies

[compare] Support diff vocab comparison, propagation of expected payloads to the backend

[compare] Implemented backend comparison logic + Added new column Vocabulary Source to comparison results

[compare-batch] Initial skeleton for the batch compare tasklet + endpoint + migration script

[batch-compare][draft][squash] Prepared initial implementation with connection pool

[batch-compare][draft][squash] Prepared initial implementation with connection pool

[batch-compare] Added Data Source Cache

[batch-compare] Diff Report Tables, migration script, entities, repositories

[batch-compare] save job info into DB

[batch-compare] saving tags

[AbstractDaoService] fixing cache of Data Sources

[compare] Extended response with more flags related to CS / Vocabs diffs

[compare] Extended compare results to contain names from both vocabs

[compare] Define concept presence in CS1/CS2 after lookup (consider descendants)

[batch-compare] Implemented filtering of concept sets search for the batch job, added new parameters from compare results to saved report

Clear source cache when checking connection

[batch-compare] Downloading Batch Compare Job Artifacts

[compare] comparing more concept fields

[compare] comparing source codes

[batch-compare] compare source codes in batch request (DTO)

[batch-compare] added isSourceCode, compareSourceCodes, Author to batch compare results entities

[batch-compare] Filtering by author

[batch-compare] compare source codes in result

[compare][batch-compare] removed in vocab flags

[batch-compare] checking for artifact presence in getList

[batch-compare] added concept set counts stats into the batch compare report

[batch-compare] include all concept fields mismatches in the report, refactoring

[batch-compare] add filter check counts

[batch-compare] authors multi select

[batch-compare] renamed Vocab1/2 to Base/Target, renamed job download permission

[batch-compare] updated report generation (minor changes, renamings, yes/no for boolean fields)

[batch-compare] not reusing shiny classes

[batch-compare] pre-generate the artifact ZIP into temp folder

[batch-compare] Allow batch compare job start / artifact download for admins only

[batch-compare] Added concept set Id filter parameter with selector

[batch-compare] Added new table for stats per job concept set (included concepts and source codes counts saving)

[batch-compare] Added included concepts and included source counts per job conceptsets into summary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants