[16.0][BKP] endpoint_auth_api_key: expect 401 when API key is missing - #156
Conversation
The `auth_api_key` authentication handler now raises `Unauthorized`: 401 for missing credentials. Update the stale assertion accordingly while retaining `403` for authenticated API keys that lack endpoint permission.
|
Hi @simahawk, |
|
The pre-commit error is: |
|
Hello @OCA/web-maintainers can you pls take a look and possibly trigger merge? |
StefanRijnhart
left a comment
There was a problem hiding this comment.
Thanks! References: OCA/server-auth#738, #106
|
Pre-commit fixed in #157 |
|
Hello @ivantodorovich can you pls take a look? |
|
fast tracking as a CI fixing backport /ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
oh right, this is going to fail. Would you mind cherry-picking #157? |
|
@StefanRijnhart your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-156-by-StefanRijnhart-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Done, thx! |
|
Great, thanks! /ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 6dba965. Thanks a lot for contributing to OCA. ❤️ |
The
auth_api_keyauthentication handler now raisesUnauthorized: 401 for missing credentials. Update the stale assertion accordingly while retaining403for authenticated API keys that lack endpoint permission.