[17.0] [IMP] storage: Remove dependency on server_environment

[yankinmax]

This is a forward-port of:

• [16.0] [IMP] fs_storage: Remove dependancy on server_environment #627

With the applied fixes introduced in:

• [16.0][FIX] fs_attachment,fs_attachment_s3,fs_storage,fs_storage_backup: fix server_environment split migration and add install/uninstall hooks #653
• [17.0][BKP] server_environment: Preserve not env managed data server-env#286

[yankinmax]

Hello @etobella @lmignon @ivantodorovich
In this PR I've cherry-picked the commits from merged 16.0 PR.
I squashed the commits that are related to one module split.
I've added new commits for storage_backend* modules.
The upgrade scripts and uninstall hooks are added for each module.
image_tag split is handled separately, because it doesn't introduce any server_env_fields override, so only need the upgrade script:

• [17.0][ADD] image_tag_environment: make server_environment an optional dependency #580

[lmignon]

Thank you for the FWP

[ivantodorovich]

Thanks!

[simahawk]

Hmm are we sure we want to make these modules auto-install?
That means that if I still have server env installed for a different app (eg: mail) this module will be installed as well w/o any reason.
Since the migration is taking care of installing the modules I would say this has to change.
Am I missing any particular reason to keep auto-install?

[yankinmax]

The reason was to keep it as much as possible similar to what it was before, so making them auto install would prove the goal, but there is no specific reason.
WDYT @ivantodorovich @lmignon @etobella ?

[lmignon]

For the next version of Odoo, we should remove the autoinstall. However, since this feature was enabled by default in existing versions, I think we should preserve the current default behaviour for backward compatibility.

BTW, I recently discovered the root cause of a strange behaviour with server.env.mixin, where some fields can no longer be edited manually. see OCA/server-env#289

[yankinmax]

Finally, I've decided to remove auto_install and tend to agree with @simahawk :
All five upgrade scripts explicitly call button_install.
Removing auto_install:

1. Preserves environment managed fields and previous behavior during upgrades.
2. Prevents fresh installations from unexpectedly installing a storage_environment_* module just because server_environment is used a dependency by another module.
3. The auto_install has never landed to recent versions actually. It was an idea to add it, but it seems there is no practical need.

[simahawk]

The dependency is getting merged 😉

[yankinmax]

The dependency is getting merged 😉

I'll update this PR without auto_install just after

[simahawk]

@yankinmax ready for merge w/ nobump, right?

[yankinmax]

@yankinmax ready for merge w/ nobump, right?

Yep, the version is bumped manually accordingly with upgrade script

[lmignon]

/ocabot merge nobmup

[OCA-git-bot]

Hi @lmignon. Your command failed:

Invalid options for command merge: nobmup.

Ocabot commands

• ocabot merge major|minor|patch|nobump
• ocabot rebase
• ocabot migration {MODULE_NAME}

More information

• ocabot documentation
• OCA guidelines, specially the "Version Numbers" section.

[lmignon]

/ocabot merge nobump

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-654-by-lmignon-bump-nobump, awaiting test results.

[OCA-git-bot]

@lmignon The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_storage_backend_sftp_environment-17.0.1.0.0.3-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading 
odoo_addon_storage_backend_sftp_environment-17.0.1.0.0.3-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests