Skip to content

[17.0][FW] geospatial: Multiple ports from 16.0#436

Merged
OCA-git-bot merged 3 commits intoOCA:17.0from
PyTech-SRL:17-port-from-16-enhance_geoengine
Feb 26, 2026
Merged

[17.0][FW] geospatial: Multiple ports from 16.0#436
OCA-git-bot merged 3 commits intoOCA:17.0from
PyTech-SRL:17-port-from-16-enhance_geoengine

Conversation

@anusriNPS
Copy link
Contributor

@anusriNPS anusriNPS commented Jan 28, 2026 •
edited
Loading

Port from 16.0:
FW: #409 - [16.0][IMP] base_geoengine: Include edit button in Popup
FW: #400 - [16.0][IMP][base_geoengine]: Update Domain for attribute_field_id
FW: #377 - [16.0][FIX] base_geoengine: Updated field label

@anusriNPS anusriNPS marked this pull request as draft January 28, 2026 09:06
@anusriNPS anusriNPS force-pushed the 17-port-from-16-enhance_geoengine branch from d4f8814 to 0d201ff Compare January 28, 2026 09:29
@anusriNPS anusriNPS marked this pull request as ready for review January 28, 2026 09:35
quirino95
quirino95 approved these changes Jan 30, 2026
View reviewed changes
Copy link

@quirino95 quirino95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yvaucher
Copy link
Member

yvaucher commented Feb 25, 2026

Superseeds #430

@yvaucher yvaucher mentioned this pull request Feb 25, 2026
Closed
@yvaucher
Copy link
Member

yvaucher commented Feb 25, 2026

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Feb 25, 2026

@yvaucher The merge process could not start, because command `git merge --no-ff -m 'Merge PR #436 into 17.0

Signed-off-by yvaucher' tmp-pr-436` failed with output:

Auto-merging geoengine_base_geolocalize/tests/test_geoengine_partner.py
CONFLICT (content): Merge conflict in geoengine_base_geolocalize/tests/test_geoengine_partner.py
Automatic merge failed; fix conflicts and then commit the result.

@yvaucher
Copy link
Member

yvaucher commented Feb 25, 2026

You can remove the last commit, didn't see you fixed in here. I already pushed an alternative.

@anusriNPS
[IMP] base_geoengine: Updated field label
7756c7a 
   Updated field label from "Params" to "Params WMS"
of params_wms
@anusriNPS
[IMP] base_geoengine: Update domain for attribute_field_id
4e47ecf 
   attribute_field_id domain is updated to use values
based on geo_field_id.model_id
@anusriNPS
[IMP] base_geoengine: Include edit button in Popup
4fdc144 
   Added edit button in popup of record shown in geoengine
view which allows user to edit values of record from
geoengine view.
@anusriNPS anusriNPS force-pushed the 17-port-from-16-enhance_geoengine branch from 0d201ff to 4fdc144 Compare February 25, 2026 14:36
@anusriNPS
Copy link
Contributor Author

anusriNPS commented Feb 25, 2026

You can remove the last commit, didn't see you fixed in here. I already pushed an alternative.

Thank you for the info.Removed the commit which was added to fix testcase issue @yvaucher

@yvaucher
Copy link
Member

yvaucher commented Feb 26, 2026

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Feb 26, 2026

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-436-by-yvaucher-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 26, 2026
@OCA-git-bot
Merge PR #436 into 17.0
8358361 
Signed-off-by yvaucher
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Feb 26, 2026

It looks like something changed on 17.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 17.0-ocabot-merge-pr-436-by-yvaucher-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 26, 2026
@OCA-git-bot
Merge PR #436 into 17.0
1009832 
Signed-off-by yvaucher
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Feb 26, 2026

It looks like something changed on 17.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 17.0-ocabot-merge-pr-436-by-yvaucher-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 62c95b7 into OCA:17.0 Feb 26, 2026
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Feb 26, 2026

Congratulations, your PR was merged at 5e038b0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@gbrito gbrito gbrito approved these changes

@quirino95 quirino95 quirino95 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anusriNPS @yvaucher @OCA-git-bot @gbrito @quirino95