-
-
Notifications
You must be signed in to change notification settings - Fork 476
[17.0][IMP] account_payment_term_extension #907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][IMP] account_payment_term_extension #907
Conversation
|
ping @MarinaAForgeFlow |
rrebollo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review. LGTM! Maybe you can add some test to pass red checks.
0ae3746 to
aa356de
Compare
|
Please do not merge yet |
|
This PR has the |
aa356de to
bb11168
Compare
|
ready for merge @etobella |
etobella
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge patch
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 4069a82. Thanks a lot for contributing to OCA. ❤️ |
@BinhexTeam
Based on
#838
… new method
Extract the paument days applicaton logic to a new method so that the logic can be easily inherited or modified