feat(contracts): separate Minter role from Admin in MembershipToken - #212
Open
endofdays7 wants to merge 9 commits into
Open
feat(contracts): separate Minter role from Admin in MembershipToken#212endofdays7 wants to merge 9 commits into
endofdays7 wants to merge 9 commits into
Conversation
- Add Minter variant to UserRole enum (between Member and Admin) - Add set_minter() / get_minter() to MembershipToken contract - Gate issue_token() on minter auth with admin fallback - Add set_minter endpoint to AccessControl contract - Add 6 behavioral tests for minter role separation - Update legacy role check to recognize Minter string Closes NovaCoreLabs1#77
- Remove unused imports/variables across 10 frontend files - Apply backend ESLint auto-fix formatting - Lint: 29 → 15 warnings (all remaining are any types and img tags)
- Rename unused `admin` param to `_admin` in set_minter - Collapse multi-line method chains for rustfmt compliance - Remove trailing blank line in test.rs
…est errors - Fix test_set_minter_fails_without_admin & test_minter_cannot_change_minter by using storage injection instead of client.set_admin() without mock_all_auths (follows existing pattern) - Fix PostCSS config: import @tailwindcss/postcss directly instead of ESM-incompatible string reference - Fix vitest config: add resolve.alias for @/ path inside workspace member config
- Fix test_minter_cannot_change_minter: use storage injection for minter too - Create backend/src/hub/README.md for multi-tenant hub module - Remove --turbopack flag from frontend build to fix lightningcss native module resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #77
Description
Closes #
Change type
Test plan
Screenshots
Breaking changes