Skip to content

sieve-editor-gui: Pin nodejs to nodejs22 - #477694

Merged
yayayayaka merged 1 commit into
NixOS:masterfrom
lzszt:sieve-editor-gui-node_js
May 26, 2026
Merged

sieve-editor-gui: Pin nodejs to nodejs22#477694
yayayayaka merged 1 commit into
NixOS:masterfrom
lzszt:sieve-editor-gui-node_js

Conversation

@lzszt

@lzszt lzszt commented Jan 7, 2026 •
edited by yayayayaka
Loading

Copy link
Copy Markdown
Contributor

Fixes the build failure of sieve-editor-gui from #477693, by pinning nodejs to version 22.

ZHF: #516381

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@lzszt

lzszt commented Jan 7, 2026

Copy link
Copy Markdown
Contributor Author

@Silver-Golden could you have a look?

@nixpkgs-ci
nixpkgs-ci Bot requested review from Silver-Golden and fugidev January 7, 2026 10:42
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 7, 2026
Silver-Golden
Silver-Golden approved these changes Jan 8, 2026
View reviewed changes

@Silver-Golden Silver-Golden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank ye so much for doing this, I have an open PR upstream (thsmi/sieve#1128) which should fix it.
Had been meaning to patch it here but got too busy.

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 8, 2026
@Silver-Golden

Silver-Golden commented Jan 8, 2026

Copy link
Copy Markdown
Member

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-ci

nixpkgs-ci Bot commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

@Silver-Golden wants to merge this PR.

Requirements to merge this PR with @NixOS/nixpkgs-merge-bot merge:

  • ✅ PR targets a development branch.
  • ✅ PR touches only files of packages in pkgs/by-name/.
  • ❌ PR is at least one of:
    • ⬜ Approved by a committer.
    • ⬜ Backported via label.
    • ⬜ Opened by a committer.
    • ⬜ Opened by r-ryantm.
  • ✅ Silver-Golden is a member of @NixOS/nixpkgs-maintainers.
  • ✅ Silver-Golden is a maintainer of all touched packages.

❌ Pull Request could not be merged (#305350)

@Silver-Golden

Silver-Golden commented Jan 8, 2026

Copy link
Copy Markdown
Member

Danm, had hoped that would work

khaneliman
khaneliman reviewed Jan 9, 2026
View reviewed changes
Comment thread pkgs/by-name/si/sieve-editor-gui/package.nix Outdated
@lzszt
lzszt force-pushed the sieve-editor-gui-node_js branch from 6114be6 to 1b339f2 Compare January 20, 2026 14:10
gepbird
gepbird reviewed Jan 23, 2026
View reviewed changes
Comment thread pkgs/by-name/si/sieve-editor-gui/package.nix
Felix Leitz @gepbird @yayayayaka
sieve-editor-gui: Pin nodejs to nodejs22
2b76436 
Co-authored-by: Gergő Gutyina <gutyina.gergo.2@gmail.com>
@yayayayaka
yayayayaka force-pushed the sieve-editor-gui-node_js branch from 7a927c8 to 2b76436 Compare May 26, 2026 14:07
yayayayaka
yayayayaka approved these changes May 26, 2026
View reviewed changes

@yayayayaka yayayayaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied the suggestion and squashed the commits together. Fixes the build.

@yayayayaka yayayayaka added the backport release-26.05 Backport PR automatically label May 26, 2026
@yayayayaka
yayayayaka enabled auto-merge May 26, 2026 14:11
@yayayayaka
yayayayaka added this pull request to the merge queue May 26, 2026
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels May 26, 2026
Merged via the queue into NixOS:master with commit d17c419 May 26, 2026
31 checks passed
@nixpkgs-ci

nixpkgs-ci Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

Successfully created backport PR for release-26.05:

@nixpkgs-ci nixpkgs-ci Bot mentioned this pull request May 26, 2026
Merged
@github-actions github-actions Bot added the 8.has: port to stable This PR already has a backport to the stable release. label May 26, 2026
hfxbse added a commit to hfxbse/nixos-config that referenced this pull request Jul 9, 2026
@hfxbse
chore: Remove redundant overlay for sieve-editor-gui
6f0224a 
Upstream fix has been merged.
See NixOS/nixpkgs#477694
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khaneliman khaneliman khaneliman left review comments
@gepbird gepbird gepbird left review comments
@yayayayaka yayayayaka yayayayaka approved these changes
@fugidev fugidev Awaiting requested review from fugidev
+1 more reviewer
@Silver-Golden Silver-Golden Silver-Golden approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. backport release-26.05 Backport PR automatically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lzszt @Silver-Golden @khaneliman @fugidev @gepbird @yayayayaka