Skip to content

ubertooth: fix build with cmake4 - #454686

Merged
Sigmanificient merged 1 commit into
NixOS:masterfrom
dani0854:ubertooth/fix-cmake
Oct 27, 2025
Merged

ubertooth: fix build with cmake4#454686
Sigmanificient merged 1 commit into
NixOS:masterfrom
dani0854:ubertooth/fix-cmake

Conversation

@dani0854

@dani0854 dani0854 commented Oct 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes cmake
#445447

PR to update cmake minimum version is already in source repository:
greatscottgadgets/ubertooth#546

But not sure if it will be merged, since last commit in this repository was 2 years ago, and last release was 5 years ago.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 22, 2025
@nix-owners
nix-owners Bot requested a review from oxzi October 22, 2025 21:45
@dani0854

dani0854 commented Oct 22, 2025

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 454686
Commit: d5091a2b729ea75123434dec307244808b90db96

x86_64-linux

✅ 1 package built:
  • ubertooth

@Sigmanificient Sigmanificient mentioned this pull request Oct 23, 2025
Closed
17 tasks
oxzi
oxzi approved these changes Oct 24, 2025
View reviewed changes

@oxzi oxzi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 24, 2025
Sigmanificient
Sigmanificient requested changes Oct 25, 2025
View reviewed changes

@Sigmanificient Sigmanificient left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, when pull requests are not yet merged into upstream, the recommendation is to vendor the patch

@dani0854
dani0854 force-pushed the ubertooth/fix-cmake branch from d5091a2 to d38bf03 Compare October 26, 2025 16:00
@dani0854 dani0854 changed the title ubertooth: fix cmake ubertooth: fix build with cmake4 Oct 26, 2025
@dani0854

dani0854 commented Oct 26, 2025

Copy link
Copy Markdown
Contributor Author

Hi, when pull requests are not yet merged into upstream, the recommendation is to vendor the patch

Done

@Sigmanificient
Sigmanificient added this pull request to the merge queue Oct 27, 2025
Merged via the queue into NixOS:master with commit 3230139 Oct 27, 2025
29 of 31 checks passed
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sigmanificient Sigmanificient Sigmanificient approved these changes
+1 more reviewer
@oxzi oxzi oxzi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dani0854 @oxzi @Sigmanificient