Skip to content

Vector store phase3 - #10

Closed
deoxyforge wants to merge 6 commits into
mainfrom
vector-store-phase2
Closed

Vector store phase3#10
deoxyforge wants to merge 6 commits into
mainfrom
vector-store-phase2

Conversation

@deoxyforge

Copy link
Copy Markdown
Collaborator

Phase 3 update done from my side.

  • Improved retrieval with top-k results
  • Added filtering for relevant code (functions/classes)
  • Cleaned noisy chunks

Changes pushed to vector-store-phase2 branch 👍

@deoxyforge deoxyforge changed the title Vector store phase2 Vector store phase3 Mar 28, 2026
@github-actions

Copy link
Copy Markdown

Automated Code Review Comment:

Bugs

  • The line if doc and len(doc.strip()) is incomplete and will cause a syntax error. It should be if doc and len(doc.strip()) > 20.

Improvements

  • The code now properly handles empty or tiny chunks by removing them from the results, which is an improvement over the previous version.
  • The addition of a filter to prioritize useful code (functions/classes) enhances the relevance of the retrieved chunks.

Suggestions

  • Consider adding error handling for cases where the results dictionary does not contain the expected keys or values.
  • The magic number 20 in the line if doc and len(doc.strip()) > 20 could be replaced with a named constant for better readability and maintainability.
  • The function could benefit from more descriptive variable names, such as relevant_documents instead of filtered.
  • The print statement could be replaced with a logging statement for better flexibility and testability.

@deoxyforge
deoxyforge requested review from haddybhaiya and pleasingsunlight and removed request for haddybhaiya March 28, 2026 10:56
@deoxyforge deoxyforge self-assigned this Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants