Add CLI Tools for Identifying Incoming UTXOs #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a CLI command to neptune-cli for obtaining the derivation index from a given address. Usage: > neptune-cli index-of <full-address> Example output: ``` key type: Generation index: 97 ```
Add a CLI command, along with an RPC function and application support, for re-scanning a particular block (identified by `BlockSelector`) for UTXOs bound a given address. The wallet database will be appraised of any new UTXOs found, and `incoming_randomness.dat` will get new entries for them. Usage: > neptune-cli rescan --block 1337 --address <address> Also!: deprecate `GenerationReceivingAddress::to_bech32m_abbreviated`. Reason: we already have `ReceivingAddress::to_display_bech32m_abbreviated`, which works for both `GenerationReceivingAddress` and `SymmetricKey` and it disagrees with this method.
Collaborator
Perhaps address should be optional, and if no address is specified then the block is scanned for all known wallet keys. (Though that could be further constrained by an optional --key-types argument that defaults to all.) |
Sword-Smith
requested changes
Nov 24, 2025
Member
Sword-Smith
left a comment
Sword-Smith
left a comment
There was a problem hiding this comment.
Looks OK to me. Let's see if we can't add a test or two though. Maybe one where block_n has already been processed, and then scan_for_utxos_announced_to_given_key is called, and you verify that nothing is returned? Such that you ensure that this recovery does not create duplicates.
Contributor
Author
|
@Sword-Smith: which parts, if any,of this PR are obviated by the new branch for faster wallet updates? If all, then let's close the PR without merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two CLI commands, the second one with RPC and application support:
neptune-cli index-of <address>Computes the derivation index from the given address.neptune-cli rescan --block 1337 --address <address>Re-scans block1337to look for output UTXOs that can be spent by the secret spending key associated with the given address, and if any are found, adds them to the wallet database and adds their randomness toincoming_randomness.dat.