Skip to content

fix(datadog): Non-map values for error key#166

Merged
AndrewDryga merged 1 commit intoNebo15:masterfrom
giddie:master
Feb 11, 2026
Merged

fix(datadog): Non-map values for error key#166
AndrewDryga merged 1 commit intoNebo15:masterfrom
giddie:master

Conversation

@giddie
Copy link
Copy Markdown
Contributor

@giddie giddie commented Jan 15, 2026

Passing an error key is a really easy footgun:

Logger.error("Something bad happened", error: "{:error, :something_bad}")

Currently, the formatter crashes because it expects error to be a map. This PR fixes the issue by assuming the caller was not trying to define the error map, and instead nests the value inside the error map:

%{
  error: %{
    kind: "error",
    message: "Something bad happened",
    error: "{:error, :something_bad}"
  }
}

@maximejimenez
Copy link
Copy Markdown

maximejimenez commented Jan 19, 2026

Hello @AndrewDryga
We are currently experiencing a similar issue, this would be a great improvement to prevent the formatter crashing 🙏
Thank you for your time!

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 100.0%. remained the same
when pulling 495b917 on giddie:master
into 1524672 on Nebo15:master.

@AndrewDryga
Copy link
Copy Markdown
Member

Thank you ❤️

@AndrewDryga AndrewDryga merged commit 1a1f630 into Nebo15:master Feb 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants