Replace WINDOWS with WIN32 in CMakeLists.txt#1059
Merged
Merged
Conversation
Fixes Windows specific code in CMake files by using the proper platform variable for Windows. This is a slightly modified version of @cedricp changes proposed in NatronGitHub#1040.
rodlie
approved these changes
Jul 2, 2025
Niik-l
pushed a commit
to Niik-l/Natron
that referenced
this pull request
Apr 8, 2026
Fixes Windows specific code in CMake files by using the proper platform variable for Windows. This is a slightly modified version of @cedricp changes proposed in NatronGitHub#1040.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:
PR Description
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
Fixes Windows specific code in CMake files by using the proper platform variable for Windows.
This is a slightly modified version of @cedricp changes proposed in #1040.
Have you tested your changes (if applicable)? If so, how?
Built locally and verified Windows specific files were properly included on Windows build.