Remove QTextCodec usage.#1043
Merged
Merged
Conversation
rodlie
approved these changes
May 5, 2025
Member
YakoYakoYokuYoku
left a comment
There was a problem hiding this comment.
Nit, can you remove the dot in the commit message?
YakoYakoYokuYoku
previously requested changes
May 5, 2025
Member
There was a problem hiding this comment.
Same as #1044. I cannot approve this based on what it was said there. Wrong PR, can't delete this comment.
118e320 to
2366598
Compare
Collaborator
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:
PR Description
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
Removes usage of QTextCodec in favor of QString::fromUtf8().
Have you tested your changes (if applicable)? If so, how?
Yes. Installer still builds and text in the About dialog box related to this change still appears correctly.