Skip to content

Remove QTextCodec usage.#1043

Merged
acolwell merged 1 commit into
NatronGitHub:RB-2.6from
acolwell:remove_qtextcodec_usage
May 5, 2025
Merged

Remove QTextCodec usage.#1043
acolwell merged 1 commit into
NatronGitHub:RB-2.6from
acolwell:remove_qtextcodec_usage

Conversation

@acolwell
Copy link
Copy Markdown
Collaborator

@acolwell acolwell commented May 4, 2025

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

Removes usage of QTextCodec in favor of QString::fromUtf8().

Have you tested your changes (if applicable)? If so, how?

Yes. Installer still builds and text in the About dialog box related to this change still appears correctly.

Copy link
Copy Markdown
Member

@YakoYakoYokuYoku YakoYakoYokuYoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, can you remove the dot in the commit message?

Copy link
Copy Markdown
Member

@YakoYakoYokuYoku YakoYakoYokuYoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #1044. I cannot approve this based on what it was said there. Wrong PR, can't delete this comment.

@YakoYakoYokuYoku YakoYakoYokuYoku dismissed their stale review May 5, 2025 12:43

Incorrect PR, mistake from my part.

@acolwell acolwell force-pushed the remove_qtextcodec_usage branch from 118e320 to 2366598 Compare May 5, 2025 13:42
@acolwell
Copy link
Copy Markdown
Collaborator Author

acolwell commented May 5, 2025

Nit, can you remove the dot in the commit message?

Done

@acolwell acolwell merged commit f5ce504 into NatronGitHub:RB-2.6 May 5, 2025
2 of 3 checks passed
@acolwell acolwell deleted the remove_qtextcodec_usage branch May 5, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants