Improvements before Qt6#1020
Merged
Merged
Conversation
Member
Author
|
Will merge tomorrow if no objections are raised. |
acolwell
requested changes
Dec 18, 2024
Collaborator
acolwell
left a comment
There was a problem hiding this comment.
In general I'm supportive of these changes and just have a few comments
1783af7 to
8f54ccd
Compare
Member
|
@YakoYakoYokuYoku please avoid force-pushing without an approval from the reviewer, except for minor stuff (e.g. typo, or 1-line trivial fix), even if you addressed the reviewer's comments. There's no hurry in merging in general. |
acolwell
added a commit
to acolwell/Natron
that referenced
this pull request
Dec 19, 2024
- Fixes build breakages caused by PR NatronGitHub#1020
acolwell
added a commit
to acolwell/Natron
that referenced
this pull request
Dec 19, 2024
- Fixes build breakages caused by PR NatronGitHub#1020
acolwell
added a commit
to acolwell/Natron
that referenced
this pull request
Dec 20, 2024
- Fixes build breakages caused by PR NatronGitHub#1020
YakoYakoYokuYoku
pushed a commit
that referenced
this pull request
Dec 20, 2024
- Fixes build breakages caused by PR #1020
10 tasks
Niik-l
pushed a commit
to Niik-l/Natron
that referenced
this pull request
Apr 8, 2026
- Fixes build breakages caused by PR NatronGitHub#1020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:
PR Description
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
This adds a pair of corrections in the build system needed for landing Qt6 support, they affect mostly the Python bindings generation and are backwards compatible with Qt5.
Show a few screenshots (if this is a visual change)
N/A.
Have you tested your changes (if applicable)? If so, how?
By building and running Natron.
Futher details of this pull request
This is a stopgap before #1019 can be merged.