Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/npm_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ on:
env:
NPM_TAG: "next"
EMULATOR_NAME: "runtime-emu"
NDK_VERSION: r23c
ANDROID_API: 29
NDK_VERSION: r27
ANDROID_API: 33
ANDROID_ABI: x86_64
NDK_ARCH: darwin

Expand All @@ -27,12 +27,12 @@ jobs:
submodules: true
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 22
registry-url: "https://registry.npmjs.org"
- uses: actions/setup-java@v3
with:
distribution: "temurin"
java-version: "17"
java-version: "21"
cache: gradle
- name: Setup Android SDK
uses: android-actions/setup-android@v2
Expand Down Expand Up @@ -93,12 +93,12 @@ jobs:
submodules: true
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 22
registry-url: "https://registry.npmjs.org"
- uses: actions/setup-java@v3
with:
distribution: "temurin"
java-version: "17"
java-version: "21"
cache: gradle
- name: Setup Android SDK
uses: android-actions/setup-android@v2
Expand Down Expand Up @@ -144,7 +144,7 @@ jobs:
steps:
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 22
registry-url: "https://registry.npmjs.org"
- uses: actions/download-artifact@v4
with:
Expand Down Expand Up @@ -173,7 +173,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 22
- name: Setup
run: npm install
- uses: actions/download-artifact@v4
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ on:
env:
NPM_TAG: "pr"
EMULATOR_NAME: "runtime-emu"
NDK_VERSION: r23c
ANDROID_API: 29
NDK_VERSION: r27
ANDROID_API: 33
ANDROID_ABI: x86_64
NDK_ARCH: darwin

Expand All @@ -24,12 +24,12 @@ jobs:
submodules: true
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 22
registry-url: "https://registry.npmjs.org"
- uses: actions/setup-java@v3
with:
distribution: "temurin"
java-version: "17"
java-version: "21"
cache: gradle
- name: Setup Android SDK
uses: android-actions/setup-android@v2
Expand Down Expand Up @@ -89,12 +89,12 @@ jobs:
submodules: true
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 22
registry-url: "https://registry.npmjs.org"
- uses: actions/setup-java@v3
with:
distribution: "temurin"
java-version: "17"
java-version: "21"
cache: gradle
- name: Setup Android SDK
uses: android-actions/setup-android@v2
Expand Down
Binary file modified gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
4 changes: 3 additions & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.9-bin.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
38 changes: 25 additions & 13 deletions gradlew

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 13 additions & 10 deletions gradlew.bat

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,19 @@
],
"version_info": {
"v8": "10.3.22.0",
"gradle": "8.4",
"gradleAndroid": "8.3.2",
"ndk": "r23c",
"ndkApiLevel": "17",
"minSdk": "17",
"compileSdk": "34",
"buildTools": "34.0.0",
"gradle": "8.7",
"gradleAndroid": "8.5.0",
"ndk": "r27",
"ndkApiLevel": "21",
"minSdk": "21",
"compileSdk": "35",
"buildTools": "35.0.0",
"kotlin": "2.0.0"
},
"// this gradle key is here for backwards compatibility - we'll phase it out slowly...": "",
"gradle": {
"version": "8.4",
"android": "8.3.2"
"version": "8.7",
"android": "8.5.0"
},
"scripts": {
"changelog": "conventional-changelog -p angular -i CHANGELOG.md -s",
Expand Down
4 changes: 2 additions & 2 deletions test-app/build-tools/android-metadata-generator/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ apply plugin: 'java'
apply plugin: 'kotlin'

java {
sourceCompatibility = '17'
targetCompatibility = '17'
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
}

// todo: check if still needed
Expand Down
4 changes: 2 additions & 2 deletions test-app/runtime-binding-generator/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ dependencies {
}

java {
sourceCompatibility = '17'
targetCompatibility = '17'
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
}

// Disable compilation tasks as these are compiled *with* the runtime and not separately
Expand Down
10 changes: 3 additions & 7 deletions test-app/runtime/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ endif (CCACHE_FOUND AND (USE_CCACHE))
# "-DANDROID_STL=c++_static" is just not enough for clang++ to find some libraries in the ndk
MESSAGE(STATUS "## ANDROID_NDK_ROOT: " ${ANDROID_NDK_ROOT})

set(COMMON_CMAKE_ARGUMENTS "-std=c++20 -Werror -Wno-vla-cxx-extension -Wno-unused-result -mstackrealign -fexceptions -fno-builtin-stpcpy -fno-rtti -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_ENABLE_REGEXP_INTERPRETER_THREADED_DISPATCH -DV8_EMBEDDED_BUILTINS")

set(COMMON_CMAKE_ARGUMENTS "-std=c++20 -Werror -Wno-unused-result -mstackrealign -fexceptions -fno-builtin-stpcpy -fno-rtti -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_ENABLE_REGEXP_INTERPRETER_THREADED_DISPATCH -DV8_EMBEDDED_BUILTINS -Wno-vla-extension -Wno-deprecated -Wno-vla-cxx-extension")


if("${ANDROID_ABI}" MATCHES "arm64-v8a$" OR "${ANDROID_ABI}" MATCHES "x86_64$")
# Enable pointer compression on 64 bit platforms
Expand Down Expand Up @@ -179,12 +181,6 @@ MESSAGE(STATUS "# CMAKE_CXX_FLAGS: " ${CMAKE_CXX_FLAGS})
target_link_libraries(NativeScript ${PROJECT_SOURCE_DIR}/src/main/libs/${ANDROID_ABI}/libzip.a)
target_link_libraries(NativeScript ${PROJECT_SOURCE_DIR}/src/main/libs/${ANDROID_ABI}/libv8_monolith.a)

if("${ANDROID_ABI}" MATCHES "armeabi-v7a$" OR "${ANDROID_ABI}" MATCHES "x86$")
# On API Level 19 and lower we need to link with android_support
# because it contains some implementation of functions such as "strtoll" and "strtoul"
MESSAGE(STATUS "# Linking with libandroid_support.a")
target_link_libraries(NativeScript ${ANDROID_NDK_ROOT}/sources/cxx-stl/llvm-libc++/libs/${ANDROID_ABI}/libandroid_support.a)
endif()

# Command info: https://cmake.org/cmake/help/v3.4/command/find_library.html
# Searches for a specified prebuilt library and stores the path as a
Expand Down
20 changes: 12 additions & 8 deletions test-app/runtime/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ if (useCCache) {

def defaultNdkVersion = "27.2.12479018"


def hasNdkVersion = project.hasProperty("ndkVersion")
if (hasNdkVersion) {
println "Runtime using NDK version " + ndkVersion
Expand Down Expand Up @@ -115,7 +114,7 @@ android {
// arguments "-DANDROID_TOOLCHAIN=clang", "-DANDROID_STL=c++_static", "-DANDROID_NDK_ROOT=${NDK_PATH}"

cppFlags "-std=c++20"
arguments "-DANDROID_STL=c++_static", "-DANDROID_NDK_ROOT=${NDK_PATH}"
arguments "-DANDROID_STL=c++_static", "-DANDROID_NDK_ROOT=${NDK_PATH}", "-DANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES=ON"
}
}

Expand All @@ -129,6 +128,11 @@ android {
}
}

compileOptions {
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
}

buildTypes {
release {
minifyEnabled false
Expand All @@ -145,13 +149,13 @@ android {
}

allprojects {
gradle.projectsEvaluated {
tasks.withType(JavaCompile).tap {
configureEach {
//options.compilerArgs << "-Xlint:all" << "-Werror"
}
}
afterEvaluate {
tasks.withType(JavaCompile).configureEach {
// remove after "-Xlint:-classfile" https://issuetracker.google.com/issues/359561906
// todo remove "-Xlint:-this-escape" after updating runtime-binding-generator
options.compilerArgs << "-Xlint:all" << "-Werror" << "-Xlint:-classfile" << "-Xlint:-this-escape"
}
}
}

dependencies {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public abstract class NativeScriptAbstractMap<K, V> implements Map<K, V> {
*
* @since 1.6
*/
public static class SimpleImmutableEntry<K, V> implements Map.Entry<K, V>, Serializable {
public static class SimpleImmutableEntry<K extends Serializable, V extends Serializable> implements Map.Entry<K, V>, Serializable {
private static final long serialVersionUID = 7138329143949025153L;

private final K key;
Expand Down Expand Up @@ -111,7 +111,7 @@ public String toString() {
*
* @since 1.6
*/
public static class SimpleEntry<K, V> implements Map.Entry<K, V>, Serializable {
public static class SimpleEntry<K extends Serializable, V extends Serializable> implements Map.Entry<K, V>, Serializable {
private static final long serialVersionUID = -8499721149061103585L;

private final K key;
Expand Down
Loading
Loading