Spectral correction model upgrades#1406
Open
mjprilliman wants to merge 17 commits into
Open
Conversation
1 task
Coverage Report for CI Build 26894993287Coverage increased (+0.007%) to 56.393%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1369 previously-covered lines in 19 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
-Add new shared file for all things spectral correction
-Add two new spectral correction functions that take in precipitable water, clearsky index
-Incorporate into pvsamv1 (gui and sdk), pvwattsv8 (sdk only for now)
-Add precipitable water, clearsky ghi, dni, dhi as options in wfreader
-Add unit tests
-TODO: consolidate all air mass calculations to one function call, with same assumptions where appropriate (separate issue to be filed for patch)
Fixes #24
Corresponding branches and PRs:
Same branch of SAM, corresponding PR
rest develop
[ link any corresponding PRs in other repos, i.e. NREL/ssc#x ]
Unit Test Impact:
[ new tests written? ] Yes
[ expected changes in unit tests or speed of tests? ] Slight changes to Sandia and IEC61853 unit tests based on change in air mass modifier calculation assumptions (more changes to come in separate issue)
[ expected changes in test_results files? ]
Checklist
Reminders- this section can be deleted
[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).
[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)