Skip to content

Omit relational inference config from NIM requests - #18

Closed
am-porter wants to merge 1 commit into
mainfrom
fix/omit-relational-inference-config
Closed

am-porter wants to merge 1 commit into
mainfrom
fix/omit-relational-inference-config

Conversation

@am-porter

Copy link
Copy Markdown
Collaborator

Summary

  • Omit inference.inference_config from relational NIM HTTP requests while retaining run_mode and use_prediction_time.
  • Reject explicitly requested inference config fields instead of silently dropping them. Keep regression statistic selection in output.prediction_statistic.
  • Update request tests and regenerate the wire payload snapshot.

Verification

  • Client and cross-package suite: 2,599 passed, 163 skipped.
  • Relational engine suite: 2,171 passed, 106 skipped.
  • Ruff, mypy, repository hygiene, attribution, and wire snapshot checks passed.

Signed-off-by: am-porter <aporter@nvidia.com>
@adi-kumo

adi-kumo commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

should this supersede #16?

@am-porter

Copy link
Copy Markdown
Collaborator Author

oh seems like your PR is more thought out for compatibility forwards and backwards, and future use of the options? I just wanted to unblock myself running some examples but I'll close this

@am-porter am-porter closed this Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants