Repository navigation
Make the clangd helper target optional and tolerate a missing source - #2352
Open
MaxFreedomPollard wants to merge 1 commit into
Open
MaxFreedomPollard wants to merge 1 commit into
MaxFreedomPollard wants to merge 1 commit into
Conversation
include/._clangd_helper_file.cpp only exists for clangd, but it was compiled on every top-level configure, and a tree that went through tar on macOS can lose the file because the "._" prefix reads as AppleDouble metadata. Add STDEXEC_BUILD_CLANGD_HELPER (default ON) and skip the target with a status message when the file is missing. Closes NVIDIA#2345. Signed-off-by: Max Freedom Pollard <272618364+MaxFreedomPollard@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2341, for #2345.
include/._clangd_helper_file.cppwas compiled on every top-level configure, which a packaging build doesn't need, and a tree that has been through tar on macOS can lose the file entirely because the._prefix reads as AppleDouble metadata. That turned a missing IDE helper into a hard configure error.This adds
STDEXEC_BUILD_CLANGD_HELPER(default ON, so day-to-day builds don't change) and skips the target with a status message when the file isn't there. I left the filename alone; happy to rename it too if you'd rather go that way.Checked by configuring with the option on, off, and with the file removed. The last case fails on main today with "Cannot find source file"; with this change it prints the status line and carries on. The helper still builds and runs with the option on.