Cleanup function spec, plus adding a few functionals#1457
Cleanup function spec, plus adding a few functionals#1457loliverhennigh wants to merge 10 commits intoNVIDIA:mainfrom
Conversation
|
|
||
| from benchmarks.physicsnemo.nn.functional.registry import FUNCTIONAL_SPECS | ||
|
|
||
| _PHASE_ORDER = ("forward", "backward") |
There was a problem hiding this comment.
We now run benchmarks on forward and backward (if backward exists). I generate two bar plots now for these instead of just the forward pass before.
There was a problem hiding this comment.
Again, these files are kinda throw away until I have the ASV setup with the CI/CD system.
Greptile SummaryThis PR successfully reorganizes the functional architecture into clearer category folders while maintaining backward compatibility and improving the interpolation implementation. Key Changes
Code QualityThe refactoring is well-executed with:
NotesSeveral functionals ( Important Files Changed
Last reviewed commit: a1183b8 |
| @@ -0,0 +1,102 @@ | |||
| # SPDX-FileCopyrightText: Copyright (c) 2023 - 2026 NVIDIA CORPORATION & AFFILIATES. | |||
There was a problem hiding this comment.
Code in the benchmarks is still a bit junky.
PhysicsNeMo Pull Request
Description
This PR is a cleanup pass for
physicsnemo.nn.functionalplus interpolation/test/benchmark updates. This PR will be followed by one more concentrated on CI integration with Github actions.What’s included:
fourier_spectral,geometry,neighbors,interpolation,regularization_parameterization). This mimics the Docs while not changing API or import paths. Imports still come fromnn.functional.xyz, this is cleans stuff up internally.grid_to_point_interpolationstructure with proper warp support and backward pass. Also added apoint_to_grid_interpolationfor fun and completness.mesh_to_voxel_fractionandmesh_poisson_disk_sample. If its too much to review these I can remove them.Overall goal: make functionals easier to navigate, easier to test, and easier to benchmark.