Note for --no-build-isolation for CUDA version mismatch#1437
Note for --no-build-isolation for CUDA version mismatch#1437
Conversation
Greptile SummaryAdded a documentation note to help users troubleshoot CUDA version mismatch errors when installing extras like
Important Files Changed
Last reviewed commit: aaf6b47 |
|
/blossom-ci |
README.md
Outdated
| uv sync --extra cu12 --extra nn-extras | ||
| ``` | ||
|
|
||
| > **Note:** If you encounter a CUDA version mismatch (e.g., "The detected |
There was a problem hiding this comment.
I think we should refine the language here - --no-build-isolation should be the way to install these packages correctly. Without that, it can cause a version mismatch.
There was a problem hiding this comment.
How about this?
Note: Extras such as
gnns,nn-extras, andtransformer-enginepull in packages that either ship only source distributions or require wheels built for a specific PyTorch and CUDA version. These should be installed with--no-build-isolation, e.g.uv sync --extra cu13 --extra gnns --no-build-isolation.
There was a problem hiding this comment.
I like this better, thanks!
|
Oh cool, awesome find! I wonder - can we specify this in
@mnabian if you have a moment, would you be able to try adding this to (Not sure which other GNN packages require no-build-isolation, but we should add those too) If this works, then we might be able to make this "just work" with |
@peterdsharpe I tested this out and ran into some other issues. We might be able to get it working, but right before the release, I’d prefer not to make big changes to the build unless you want to give this a try. |
|
/blossom-ci |
PhysicsNeMo Pull Request
Description
Checklist
Dependencies
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.