Remove tracked .bak files that violate the project's own .gitignore - #16
Merged
psgundecha-nv merged 2 commits intoSep 15, 2026
Merged
Conversation
nvflow/recipes/finance/datasets/finance_agent/eval.jsonl.bak (60KB) and public.csv.bak (56KB) were committed in the initial public release despite .gitignore explicitly listing *.bak / *.bak-* -- .gitignore doesn't retroactively untrack files already committed before the pattern was added. Confirmed via grep that no .py/.yaml/.md file references either filename, and `git log --follow` shows neither has been touched since the initial commit -- these are stale backup artifacts with no apparent purpose, not a fallback data source anything depends on. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Anil Balireddy <anilbalireddi@gmail.com>
sgharghabi
reviewed
Sep 15, 2026
sgharghabi
left a comment
There was a problem hiding this comment.
Thanks for the fix it looks good to me!
I would appreciate if you can also fix the the .docerignore file to remove this comment:
-# Editor/local backups. Scope to cluster-config backups only -- a bare *.bak*
-# would also drop TRACKED dataset files (e.g. datasets/finance_agent/*.bak),
-# which then show up as phantom deletions and mark the baked tree dirty.
-cluster_configs/*.bak*
and include all +.bak
Thanks
…cked Per review feedback from @sgharghabi on this PR: the previous scoping to cluster_configs/*.bak* (and its explanatory comment) existed specifically to avoid excluding the two TRACKED dataset .bak files this PR removes (nvflow/recipes/finance/datasets/finance_agent/{eval.jsonl,public.csv}.bak). With those gone, no tracked file anywhere matches *.bak*, so the narrow scoping and its now-stale rationale comment can go -- a plain *.bak* covers editor/local backups repo-wide as originally intended. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Anil Balireddy <anilbalireddi@gmail.com>
Contributor
Author
|
Good catch, thanks! Pushed a fixup — since this PR already removes the two tracked |
sgharghabi
approved these changes
Sep 15, 2026
sgharghabi
approved these changes
Sep 15, 2026
sgharghabi
left a comment
There was a problem hiding this comment.
cc @psgundecha-nv for the final approval. Thanks
psgundecha-nv
self-requested a review
September 15, 2026 23:29
psgundecha-nv
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nvflow/recipes/finance/datasets/finance_agent/eval.jsonl.bak(60KB) andpublic.csv.bak(56KB) were committed in the initial public release despite.gitignoreexplicitly listing*.bak/*.bak-*(.gitignore:89-90)..gitignoredoesn't retroactively untrack files that were already committed before the pattern was added, so these two have been sitting in the repo regardless.Confirmed before removing:
grep -rn "eval.jsonl.bak\|public.csv.bak"across.py/.yaml/.mdfinds zero references — nothing reads these as a fallback/backup data sourcegit log --followshows neither file has been touched since543d93e(Initial public release) — genuinely stale artifacts, not active backupsTest plan
pytest tests/suite passes (339 passed, 3 pre-existing skips) — no test or code depended on either file🤖 Generated with Claude Code