Skip to content

Remove tracked .bak files that violate the project's own .gitignore - #16

Merged
psgundecha-nv merged 2 commits into
NVIDIA:mainfrom
Anilreddy2309:cleanup/remove-tracked-bak-files
Sep 15, 2026
Merged

psgundecha-nv merged 2 commits into
NVIDIA:mainfrom
Anilreddy2309:cleanup/remove-tracked-bak-files

Conversation

@Anilreddy2309

Copy link
Copy Markdown
Contributor

Summary

nvflow/recipes/finance/datasets/finance_agent/eval.jsonl.bak (60KB) and public.csv.bak (56KB) were committed in the initial public release despite .gitignore explicitly listing *.bak / *.bak-* (.gitignore:89-90). .gitignore doesn't retroactively untrack files that were already committed before the pattern was added, so these two have been sitting in the repo regardless.

Confirmed before removing:

  • grep -rn "eval.jsonl.bak\|public.csv.bak" across .py/.yaml/.md finds zero references — nothing reads these as a fallback/backup data source
  • git log --follow shows neither file has been touched since 543d93e (Initial public release) — genuinely stale artifacts, not active backups

Test plan

  • Full pytest tests/ suite passes (339 passed, 3 pre-existing skips) — no test or code depended on either file

🤖 Generated with Claude Code

nvflow/recipes/finance/datasets/finance_agent/eval.jsonl.bak (60KB) and
public.csv.bak (56KB) were committed in the initial public release
despite .gitignore explicitly listing *.bak / *.bak-* -- .gitignore
doesn't retroactively untrack files already committed before the
pattern was added.

Confirmed via grep that no .py/.yaml/.md file references either
filename, and `git log --follow` shows neither has been touched since
the initial commit -- these are stale backup artifacts with no
apparent purpose, not a fallback data source anything depends on.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Anil Balireddy <anilbalireddi@gmail.com>
@Anilreddy2309
Anilreddy2309 requested a review from a team September 11, 2026 17:19

@sgharghabi sgharghabi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix it looks good to me!
I would appreciate if you can also fix the the .docerignore file to remove this comment:

-# Editor/local backups. Scope to cluster-config backups only -- a bare *.bak*
-# would also drop TRACKED dataset files (e.g. datasets/finance_agent/*.bak),
-# which then show up as phantom deletions and mark the baked tree dirty.
-cluster_configs/*.bak*

and include all +.bak

Thanks

…cked

Per review feedback from @sgharghabi on this PR: the previous scoping to
cluster_configs/*.bak* (and its explanatory comment) existed specifically
to avoid excluding the two TRACKED dataset .bak files this PR removes
(nvflow/recipes/finance/datasets/finance_agent/{eval.jsonl,public.csv}.bak).
With those gone, no tracked file anywhere matches *.bak*, so the narrow
scoping and its now-stale rationale comment can go -- a plain *.bak*
covers editor/local backups repo-wide as originally intended.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Anil Balireddy <anilbalireddi@gmail.com>
@Anilreddy2309

Copy link
Copy Markdown
Contributor Author

Good catch, thanks! Pushed a fixup — since this PR already removes the two tracked .bak files, the scoping (and its rationale comment) no longer applies, so I broadened it to a plain *.bak* as suggested.

@sgharghabi sgharghabi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @psgundecha-nv for the final approval. Thanks

@psgundecha-nv
psgundecha-nv self-requested a review September 15, 2026 23:29
@psgundecha-nv
psgundecha-nv merged commit 2fa3c5b into NVIDIA:main Sep 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants