Skip to content

Fix stream view construction in new benchmark - #23933

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
wence-:wence/fix/benchmark-stream-ref
Sep 2, 2026
Merged

rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
wence-:wence/fix/benchmark-stream-ref

Conversation

@wence-

@wence- wence- commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Description

Adapt the new benchmark from #23889 to the stream_ref changes of #23770.

These two "conflicted" but not in a merge-conflict way.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence-
wence- requested a review from a team as a code owner September 2, 2026 09:19
@wence-
wence- requested review from bdice and misiugodfrey September 2, 2026 09:19
@github-actions github-actions Bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 2, 2026
@wence- wence- added bug Something isn't working non-breaking Non-breaking change and removed libcudf Affects libcudf (C++/CUDA) code. labels Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7c211578-7d20-4745-bffb-1572038c91aa

📥 Commits

Reviewing files that changed from the base of the PR and between ff325a4 and a66d867.

📒 Files selected for processing (1)
  • cpp/benchmarks/dictionary/concatenate.cpp

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Updated the dictionary concatenation benchmark’s CUDA stream handling for compatibility with the current stream interface.

Walkthrough

The dictionary concatenate benchmark now passes its CUDA stream to nvbench through stream.get() instead of stream.value().

Changes

Dictionary benchmark

Layer / File(s) Summary
Update benchmark stream configuration
cpp/benchmarks/dictionary/concatenate.cpp
bench_dictionary_concatenate_indices now uses stream.get() when configuring nvbench.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to a66d8

This localized benchmark fix changes how the stream is passed during setup and introduces no actionable merge-blocking risk; it is merge-ready after normal checks and review.

Suggested reviewers: vyasr

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: fixing stream view construction in the new benchmark.
Description check ✅ Passed The description explains that the benchmark must align with the stream_ref changes and addresses the conflict between the prior changes.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@davidwendt

Copy link
Copy Markdown
Contributor

/merge

@rapids-bot
rapids-bot Bot merged commit 5761f46 into NVIDIA:main Sep 2, 2026
156 of 157 checks passed
@wence-
wence- deleted the wence/fix/benchmark-stream-ref branch September 2, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants