Add advisory audit for NVIDIA API deprecations [reduced-it] - #15867
Open
gerashegalov wants to merge 5 commits into
Open
Add advisory audit for NVIDIA API deprecations [reduced-it]#15867gerashegalov wants to merge 5 commits into
gerashegalov wants to merge 5 commits into
Conversation
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Contributor
Greptile SummaryThe PR makes NVIDIA-owned Scala API deprecations advisory while retaining fatal handling for other deprecations, and adds an optional workflow job that aggregates compiler diagnostics from Maven matrix logs.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains in the eligible follow-up review scope. No blocking failure remains. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
Matrix[Maven build matrix jobs] --> Logs[Completed GitHub Actions job logs]
Logs --> Audit[Jython deprecation audit]
Audit --> Parse[Parse compiler diagnostics]
Parse --> Summary[GitHub job summary and annotations]
Parse --> Report[JSON report artifact]
Parse --> Status{Findings or collection failures?}
Status -->|Yes| Fail[Fail optional audit job]
Status -->|No| Pass[Pass audit job]
Reviews (5): Last reviewed commit: "Keep deprecation audit on root POM" | Re-trigger Greptile |
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Collaborator
Author
|
build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #15825.
Description
Deprecation annotations in NVIDIA-owned dependencies can land before cudf-spark can consume an
artifact containing the replacement API. With fatal Scala warnings, that ordering breaks unrelated
cudf-spark pull requests even though no compatible migration is available yet.
This change keeps deprecations from NVIDIA-owned cuDF Java, cudf-spark-jni, and
cudf-spark-private APIs visible as compiler information while retaining fatal handling for
third-party deprecations. Because cudf-spark-private does not have one artifact-specific namespace,
the policy covers its NVIDIA-owned package roots and an exact
PartialAggUtilsbridge symbol; anadjacent Spark symbol remains fatal as a regression control.
The Maven pull-request workflow also gains an optional fan-in audit that downloads completed
matrix-job logs and reports compiler deprecations in the job summary and annotations. Findings or
incomplete log collection fail this optional check so contributors inspect it, while the report is
still uploaded and the build jobs remain authoritative. Log collection validates GitHub signed
redirects and never forwards the repository token to the signed download URL. Contributor
documentation now describes the staged cross-repository deprecation lifecycle. Both the compiler-
policy fixture checker and log audit run through Maven's existing Jython 2.7.3 dependency, so this
change does not add a host Python prerequisite; the existing resource-nesting check remains on
Python 3 for a dedicated follow-up port.
Validation performed:
mvn -N -Dbuildver=330 verifymvn -N -f scala2.13/pom.xml -Dbuildver=350 verifygit diff --checkChecklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance