[libcu++] Replace cuda::__bad_any_cast with std::bad_any_cast#8799
Open
davebayer wants to merge 1 commit into
Open
[libcu++] Replace cuda::__bad_any_cast with std::bad_any_cast#8799davebayer wants to merge 1 commit into
cuda::__bad_any_cast with std::bad_any_cast#8799davebayer wants to merge 1 commit into
Conversation
davebayer
force-pushed
the
remove_bad_any_cast
branch
from
50898b3 to
bd726d6
Compare
Jacobfaib
reviewed
May 4, 2026
davebayer
force-pushed
the
remove_bad_any_cast
branch
from
bd726d6 to
aaf4dba
Compare
davebayer
force-pushed
the
remove_bad_any_cast
branch
from
aaf4dba to
8d69cbc
Compare
Contributor
🥳 CI Workflow Results🟩 Finished in 2h 21m: Pass: 100%/110 | Total: 2d 16h | Max: 1h 24m | Hits: 92%/316882See results here. |
miscco
reviewed
May 5, 2026
| #endif // no system header | ||
|
|
||
| #if _CCCL_HOSTED() | ||
| # include <any> |
Contributor
There was a problem hiding this comment.
Did we check whether <typeinfo> would be smaller?
miscco
reviewed
May 5, 2026
Contributor
miscco
left a comment
miscco
left a comment
There was a problem hiding this comment.
Question about which host header to include
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of the host standard libraries come with
<any>header, thus we should just throwstd::bad_any_castinstead of the internalcuda::__bad_any_cast.