extend the concept portability macros to support _Convertible_to(T) and _Derived_from(T)#8768
Open
ericniebler wants to merge 2 commits into
Conversation
… and `_Derived_from(T)`
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test d74e764 |
Contributor
Author
|
/ok to test 804f994 |
Contributor
🥳 CI Workflow Results🟩 Finished in 2h 29m: Pass: 100%/110 | Total: 2d 01h | Max: 2h 28m | Hits: 82%/316700See results here. |
Jacobfaib
reviewed
May 1, 2026
| // Converts "_Same_as(TYPE) EXPR..." to "decltype(EXPR...), TYPE" | ||
| # define _CCCL_CONCEPT_SAME_AS_REQUIREMENT_(_REQ) \ | ||
| _CCCL_CONCEPT_GET_TYPE_FROM_SAME_AS_(_REQ), decltype(_CCCL_CONCEPT_EAT_SAME_AS_(_REQ)) | ||
| decltype(_CCCL_CONCEPT_EAT_SAME_AS_(_REQ)), _CCCL_CONCEPT_GET_TYPE_FROM_SAME_AS_(_REQ) |
Contributor
Author
There was a problem hiding this comment.
Just for consistency with the argument order for the _Derived_from and _Convertible_to cases
miscco
reviewed
May 4, 2026
| requires(::cuda::std::ranges::contiguous_range<_Tp>), // | ||
| requires(::cuda::std::convertible_to<_Tp, __as_span_t<_Tp>>)); | ||
| _CCCL_CONCEPT __spannable = _CCCL_REQUIRES_EXPR((_Tp), _Tp&& __value)( // | ||
| _Satisfies(cuda::std::ranges::contiguous_range)::cuda::std::forward<_Tp>(__value), // |
Contributor
There was a problem hiding this comment.
Hm, this might be troublesome, because we might run into namespace issues without the full qualification. What is the reason for dropping those?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
in private conversation, @miscco mentioned that he wanted a
_Convertible_toextension to the concept portability macros so that he could replace:with
for good measure this PR also adds a
_Derived_frommacro, which i have wanted at times.finally, this PR makes use of the new macros in
cuda/__algorithm/common.h.Checklist