Repository navigation
feat(nvsentinel): add opt-in log collector mixin #3354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2,946
−431
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9e1722d
feat(nvsentinel): add opt-in log collector mixin
varmesh 8fb6f22
fix(nvsentinel): run log collector e2e on ubuntu-22.04 and check env …
varmesh 0ac5059
fix(nvsentinel): preload file server images and harden log collector …
varmesh 108c3b5
fix(nvsentinel): pin the file server init image to docker.io busybox
varmesh 7b9410b
fix(nvsentinel): check the file server's StorageClass and harden the …
varmesh d75b714
fix(nvsentinel): skip StorageClass warnings when the bundle names a c…
varmesh d8f1be3
fix(nvsentinel): address log collector review comments
varmesh 7f7d44d
test(bundler): regenerate render golden after rebasing on main
varmesh 42e4c37
Merge branch 'main' into feat/nvsentinel-log-collector
mchmarny d4e7f7c
Merge branch 'main' into feat/nvsentinel-log-collector
mchmarny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,157 @@ | ||
| # Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| # Runtime Kind test for the nvsentinel-log-collector mixin. | ||
| # | ||
| # Installs the remediation step with the log collector, and the health events | ||
| # analyzer that live remediation requires, via the bundle's own install.sh, | ||
| # sends one synthetic GPU fault into platform-connectors, and checks | ||
| # that fault-remediation runs the collector Job on the node, that the bug report | ||
| # it uploads is listed by the in-cluster file server, that the file server's | ||
| # volume took the --storage-class value, and that the GPU reset is requested | ||
| # only after collection. The collector runs in its MOCK_MODE: a Kind node has no | ||
| # GPU driver. Not wired into `make qualify`: it needs a Kind cluster. | ||
| # | ||
| # Path filter kept narrow for the same reason as nvsentinel-preflight-e2e.yaml. | ||
|
|
||
| name: NVSentinel Log Collector E2E | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| paths: &paths | ||
| - 'recipes/mixins/nvsentinel-remediation.yaml' | ||
| - 'recipes/mixins/nvsentinel-health-events-analyzer.yaml' | ||
| - 'recipes/mixins/nvsentinel-log-collector.yaml' | ||
| - 'pkg/bundler/validations/nvsentinel_log_collector.go' | ||
| - 'pkg/bundler/validations/checks.go' | ||
| - 'recipes/registry.yaml' | ||
| - 'recipes/components/nvsentinel/**' | ||
| - 'recipes/components/nvsentinel-mongodb/**' | ||
| - 'recipes/components/psmdb-operator/**' | ||
| # The tested overlay inherits kind.yaml, which inherits base.yaml, and | ||
| # base.yaml is where nvsentinel enters the chain at all. | ||
| - 'recipes/overlays/h100-kind-training.yaml' | ||
| - 'recipes/overlays/kind.yaml' | ||
| - 'recipes/overlays/base.yaml' | ||
| # The run installs cert-manager, for the Percona cluster's certificates, | ||
| # and prometheus-operator-crds from the bundle. | ||
| - 'recipes/components/cert-manager/**' | ||
| - 'recipes/components/prometheus-operator-crds/**' | ||
| - 'tests/e2e/nvsentinel-log-collector/**' | ||
| - 'pkg/bundler/deployer/localformat/templates/**' | ||
| # run.sh sources tools/common and is invoked through a make target. | ||
| - 'tools/common' | ||
| - 'Makefile' | ||
| - '.github/workflows/nvsentinel-log-collector-e2e.yaml' | ||
| - '.github/actions/setup-build-tools/**' | ||
| - '.github/actions/prep-kind-runner/**' | ||
| - '.github/actions/load-versions/**' | ||
| - '.settings.yaml' | ||
| pull_request: | ||
| branches: [main] | ||
| paths: *paths | ||
| workflow_dispatch: {} | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | ||
| cancel-in-progress: ${{ github.event_name == 'pull_request' }} | ||
|
|
||
| jobs: | ||
| test: | ||
| name: NVSentinel Log Collector E2E | ||
| # mongod 8.0 before 8.0.35 exits at startup on the ubuntu-24.04 image's | ||
| # 7.0 kernel (https://jira.mongodb.org/browse/SERVER-131779). Return to | ||
| # ubuntu-24.04 once the Percona MongoDB pin is 8.0.35 or newer. | ||
| runs-on: ubuntu-22.04 | ||
| # The script's bounded waits sum to ~70 minutes worst case (node Ready 2, | ||
| # cert-manager 10, Percona datastore 15, nvsentinel rollout 15, event | ||
| # delivery 3, collection 15, reset request 5, proto fetch 1, port-forward | ||
| # and fetches 4), before kind create, go build and the installs' own helm | ||
| # waits. A healthy run takes a fraction of that. | ||
| timeout-minutes: 100 | ||
| steps: | ||
| - name: Checkout Code | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Load versions | ||
| id: versions | ||
| uses: ./.github/actions/load-versions | ||
|
|
||
| - name: Prep Kind runner | ||
| uses: ./.github/actions/prep-kind-runner | ||
|
|
||
| - name: Set up Go | ||
| uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 | ||
| with: | ||
| go-version: ${{ steps.versions.outputs.go }} | ||
| cache: false | ||
|
|
||
| # run.sh's has_tools gate also needs jq and curl, which the runner image | ||
| # already ships; installing only some of the rest fails the lane before | ||
| # it exercises anything. | ||
| - name: Install Kind, kubectl, Helm and yq | ||
| uses: ./.github/actions/setup-build-tools | ||
| with: | ||
| install_kind: 'true' | ||
| kind_version: '${{ steps.versions.outputs.kind }}' | ||
| install_kubectl: 'true' | ||
| kubectl_version: '${{ steps.versions.outputs.kubectl }}' | ||
| install_helm: 'true' | ||
| helm_version: '${{ steps.versions.outputs.helm }}' | ||
| install_yq: 'true' | ||
| yq_version: '${{ steps.versions.outputs.yq }}' | ||
|
|
||
| # KEEP_CLUSTER so the cluster survives for the diagnostics below; the | ||
| # script's own EXIT trap would otherwise delete it before they run, | ||
| # leaving a failure with nothing to inspect. The always() step after | ||
| # diagnostics does the teardown instead. | ||
| - name: Run nvsentinel-log-collector e2e | ||
| env: | ||
| KEEP_CLUSTER: 'true' | ||
| run: make nvsentinel-log-collector-e2e | ||
|
|
||
| # run.sh writes its kubeconfig inside a mktemp dir and removes that dir on | ||
| # exit, so KEEP_CLUSTER leaves the cluster running but no credentials to | ||
| # reach it. Re-export before querying anything. cancelled() because a | ||
| # job timeout cancels rather than fails. | ||
| - name: Collect diagnostics on failure | ||
| if: ${{ failure() || cancelled() }} | ||
| run: | | ||
| set +e | ||
| cluster=aicr-nvsentinel-lc-e2e | ||
| export KUBECONFIG="${RUNNER_TEMP}/lc-diag.kubeconfig" | ||
| kind export kubeconfig --name "$cluster" --kubeconfig "$KUBECONFIG" || exit 0 | ||
| kubectl get pods -A | ||
| kubectl get node -o yaml | ||
| kubectl -n nvsentinel get pvc,statefulset,deployment,job,perconaservermongodb,certificate | ||
| kubectl -n nvsentinel get events --sort-by=.lastTimestamp | ||
| kubectl -n nvsentinel describe pods --selector='!job-name' | ||
| kubectl get gpuresets.janitor.dgxc.nvidia.com -A -o yaml | ||
| kubectl -n nvsentinel logs -l app=log-collector --tail=200 | ||
| for d in fault-quarantine node-drainer fault-remediation janitor nvsentinel-incluster-file-server; do | ||
| kubectl -n nvsentinel logs "deployment/$d" --tail=200 | ||
| done | ||
| kubectl -n nvsentinel logs daemonset/platform-connectors --tail=200 | ||
| kubectl -n nvsentinel logs deployment/psmdb-operator --tail=200 | ||
| kubectl -n nvsentinel logs statefulset/nvsentinel-mongodb-rs0 -c mongod --tail=100 | ||
|
|
||
| - name: Delete Kind cluster | ||
| if: ${{ always() }} | ||
| run: kind delete cluster --name aicr-nvsentinel-lc-e2e || true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.