Skip to content

[Bug]: kubeflow-trainer values set seven keys the 2.2.0 chart never reads #3365

Open

Description

@vineeth-bandi

Prerequisites

  • I searched existing issues and found no duplicates
  • I can reproduce this issue consistently
  • This is not a security vulnerability

Bug Description

recipes/components/kubeflow-trainer/values.yaml sets seven keys the pinned chart (kubeflow-trainer 2.2.0) does not read (values.yaml#L34-L85):

  • manager.leaderElection
  • manager.logging
  • manager.serviceAccount
  • manager.podSecurityContext
  • crds.install
  • webhook.enabled
  • webhook.port

The chart has no values schema, so Helm accepts them silently, and changing them does not change the rendered manifests. Nothing deploys wrong today because the chart defaults happen to match, but the file claims configuration AICR doesn't control (e.g. pod-level runAsNonRoot; the actual runAsNonRoot comes only from the chart's container-level default). The keys have never been read by any pinned version (2.1.0 or 2.2.0).

Related: #3338 (open) removes the similar dead manager.metrics.serviceMonitor.enabled.

Impact

Low (minor issue)

Component

Recipe engine / data

Regression?

No, this is a new use case

Steps to Reproduce

  1. aicr recipe --service eks --accelerator h100 --intent training --os ubuntu --platform kubeflow -o recipe.yaml && aicr bundle -r recipe.yaml -o ./bundle
  2. helm pull oci://ghcr.io/kubeflow/charts/kubeflow-trainer --version 2.2.0 --untar --untardir ./chart
  3. helm template kubeflow-trainer ./chart/kubeflow-trainer -n kubeflow -f ./bundle/012-kubeflow-trainer/values.yaml > base.yaml
  4. Change any of the keys above (e.g. .webhook.enabled=false, .manager.podSecurityContext={"runAsUser":0}), render again, and diff against base.yaml.

Expected Behavior

Every key in the values file affects the rendered output.

Actual Behavior

The diff is empty for all seven keys. Changing keys the chart does read (e.g. manager.resources, jobset.install) produces a diff.

Environment

  • AICR version: main at a2f7cb274
  • Install method: build from source
  • Service: any recipe that includes kubeflow-trainer
  • Kubernetes version: n/a (render-time)
  • OS + version: n/a
  • Kernel version: n/a
  • GPU type: any
  • Workload intent: training

Activity

  1. La1itchauhan commented on Oct 25, 2026

    @La1itchauhan
    Contributor

    Hey @vineeth-bandi, I would like to work on this issue.

    /assign

  2. La1itchauhan commented on Oct 25, 2026

    @La1itchauhan
    Contributor

    /assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area/recipestheme/recipesRecipe expansion, overlays, mixins, and component registry

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions